Introduce an abstraction to write to a field.

Introduce an abstraction to write to a field.

BUG=
R=ishell@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20792

[Toon Verwaest, 2014-04-15 14:01:24]

PTAL

[Igor Sheludko, 2014-04-16 09:50:03]

Nice cleanup!

lgtm with nits:

https://codereview.chromium.org/236063016/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/236063016/diff/1/src/objects.cc#newcode3954
src/objects.cc:3954: void JSObject::WriteToField(int descriptor, Object* value)
{
Suggestion: you are not using handles here, what about adding
DisallowAllocationScope?

https://codereview.chromium.org/236063016/diff/1/src/objects.cc#newcode5205
src/objects.cc:5205: ASSERT(descriptors->GetType(sorted_index) == FIELD);
Does it make sense to move this assert to WriteToField?

https://codereview.chromium.org/236063016/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/236063016/diff/1/src/objects.h#newcode2910
src/objects.h:2910: 
Extra empty line?

[Toon Verwaest, 2014-04-16 11:04:46]

Addressed comments

[Toon Verwaest, 2014-04-16 11:11:27]

Committed patchset #2 manually as r20792 (presubmit successful).