Issue 236063002: Make landmines.py ignore eclipse gyp generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 236063002: Make landmines.py ignore eclipse gyp generator. (Closed)

Created:
6 years, 8 months ago by newt (away)

Modified:
6 years, 8 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make landmines.py ignore eclipse gyp generator. The eclipse gyp generator is used to generate eclipse project files, not to actually build anything. Landmines should return early if the gyp generator is eclipse rather than failing with the error "Unexpected GYP_GENERATORS (eclipse)" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263438

Patch Set 1 #

Total comments: 1

Patch Set 2 : [ to ( #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/landmines.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/236063002/diff/1/build/landmines.py File build/landmines.py (right): https://codereview.chromium.org/236063002/diff/1/build/landmines.py#newcode116 build/landmines.py:116: if landmine_utils.builder() in ['dump_dependency_json', 'eclipse']: nit; ('dump_dependency_json', 'eclipse') ...

6 years, 8 months ago (2014-04-11 22:24:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/236063002/20001

6 years, 8 months ago (2014-04-11 22:28:21 UTC) #4

Message was sent while issue was closed.

Change committed as 263438

Expand Messages | Collapse Messages