Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: tools/gn/scope_per_file_provider_unittest.cc

Issue 23606031: GN: Use build directory for CD for scripts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/scope_per_file_provider.cc ('k') | tools/gn/secondary/base/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/scope_per_file_provider_unittest.cc
diff --git a/tools/gn/scope_per_file_provider_unittest.cc b/tools/gn/scope_per_file_provider_unittest.cc
index 7e195ce8721aa5f769cee9da858e369feeaa3af6..4abada8eca3bc47fbd7c89767f4f316c95176558 100644
--- a/tools/gn/scope_per_file_provider_unittest.cc
+++ b/tools/gn/scope_per_file_provider_unittest.cc
@@ -31,20 +31,12 @@ TEST(ScopePerFileProvider, Expected) {
variables::kCurrentToolchain)->string_value());
EXPECT_EQ("//toolchain:default", provider.GetProgrammaticValue(
variables::kDefaultToolchain)->string_value());
- EXPECT_EQ("../..",provider.GetProgrammaticValue(
- variables::kRelativeBuildToSourceRootDir)->string_value());
- EXPECT_EQ("../out/Debug", provider.GetProgrammaticValue(
- variables::kRelativeRootOutputDir)->string_value());
- EXPECT_EQ("../out/Debug/gen", provider.GetProgrammaticValue(
- variables::kRelativeRootGenDir)->string_value());
- EXPECT_EQ("..", provider.GetProgrammaticValue(
- variables::kRelativeSourceRootDir)->string_value());
- EXPECT_EQ("../out/Debug/obj/source", provider.GetProgrammaticValue(
- variables::kRelativeTargetOutputDir)->string_value());
- EXPECT_EQ("../out/Debug/gen/source", provider.GetProgrammaticValue(
- variables::kRelativeTargetGenDir)->string_value());
EXPECT_EQ("//out/Debug/gen",provider.GetProgrammaticValue(
variables::kRootGenDir)->string_value());
+ EXPECT_EQ("//out/Debug",provider.GetProgrammaticValue(
+ variables::kRootOutDir)->string_value());
EXPECT_EQ("//out/Debug/gen/source",provider.GetProgrammaticValue(
variables::kTargetGenDir)->string_value());
+ EXPECT_EQ("//out/Debug/obj/source",provider.GetProgrammaticValue(
+ variables::kTargetOutDir)->string_value());
}
« no previous file with comments | « tools/gn/scope_per_file_provider.cc ('k') | tools/gn/secondary/base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698