Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: tools/gn/ninja_script_target_writer.h

Issue 23606031: GN: Use build directory for CD for scripts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/gn.gyp ('k') | tools/gn/ninja_script_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_script_target_writer.h
diff --git a/tools/gn/ninja_script_target_writer.h b/tools/gn/ninja_script_target_writer.h
index ec954299afc3989e7f9b47a1007869f89fddff75..37bfe1491822c6489a72a5246e6ad7247f2495a5 100644
--- a/tools/gn/ninja_script_target_writer.h
+++ b/tools/gn/ninja_script_target_writer.h
@@ -24,7 +24,7 @@ class NinjaScriptTargetWriter : public NinjaTargetWriter {
// Returns the name of the custom rule generated. This will be based on the
// target name, and will include the string "$unique_name" if there are
// multiple inputs.
- std::string WriteRuleDefinition(const std::string& script_relative_to_cd);
+ std::string WriteRuleDefinition();
// Writes the rules for compiling each source, writing all output files
// to the given vector.
@@ -33,8 +33,6 @@ class NinjaScriptTargetWriter : public NinjaTargetWriter {
// to each build step, it starts with a "|" if it's nonempty.
void WriteSourceRules(const std::string& custom_rule_name,
const std::string& implicit_deps,
- const SourceDir& script_cd,
- const std::string& script_cd_to_root,
std::vector<OutputFile>* output_files);
void WriteArg(const std::string& arg);
« no previous file with comments | « tools/gn/gn.gyp ('k') | tools/gn/ninja_script_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698