 Chromium Code Reviews
 Chromium Code Reviews Issue 23606031:
  GN: Use build directory for CD for scripts  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 23606031:
  GN: Use build directory for CD for scripts  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW | 
|---|---|
| 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be | 
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. | 
| 4 | 4 | 
| 5 # Base compiler configuration. | 5 # Base compiler configuration. | 
| 6 config("compiler") { | 6 config("compiler") { | 
| 7 includes = [ "//" ] | 7 includes = [ "//" ] | 
| 8 if (is_win) { | 8 if (is_win) { | 
| 9 cflags = [ | 9 cflags = [ | 
| 10 # TODO(brettw) these probably need to be refactored. | 10 # TODO(brettw) these probably need to be refactored. | 
| (...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 83 } | 83 } | 
| 84 | 84 | 
| 85 # Linux-specific compiler flags setup. | 85 # Linux-specific compiler flags setup. | 
| 86 # ------------------------------------ | 86 # ------------------------------------ | 
| 87 if (is_linux) { | 87 if (is_linux) { | 
| 88 cflags += [ | 88 cflags += [ | 
| 89 "-fPIC", | 89 "-fPIC", | 
| 90 "-pthread", | 90 "-pthread", | 
| 91 "-pipe", # Use pipes for communicating between sub-processes. Faster. | 91 "-pipe", # Use pipes for communicating between sub-processes. Faster. | 
| 92 ] | 92 ] | 
| 93 gold_path = to_build_path("//third_party/gold") | |
| 93 ldflags += [ | 94 ldflags += [ | 
| 94 # Use Gold for linking: it is checked out in the source tree. | 95 # Use Gold for linking: it is checked out in the source tree. | 
| 95 "-B$relative_build_to_source_root_dir/third_party/gold", | 96 "-B$gold_path", | 
| 
scottmg
2013/09/14 04:53:16
... hmm, i see that's more like what you had befor
 | |
| 96 | 97 | 
| 97 "-fPIC", | 98 "-fPIC", | 
| 98 "-pthread", | 99 "-pthread", | 
| 99 "-Wl,-z,noexecstack", | 100 "-Wl,-z,noexecstack", | 
| 100 | 101 | 
| 101 # TODO(brettw) gold linker flags, only target. | 102 # TODO(brettw) gold linker flags, only target. | 
| 102 # There seems to be a conflict of --icf and -pie in gold which can | 103 # There seems to be a conflict of --icf and -pie in gold which can | 
| 103 # generate crashy binaries. As a security measure, -pie takes | 104 # generate crashy binaries. As a security measure, -pie takes | 
| 104 # precendence for now. | 105 # precendence for now. | 
| 105 # TODO(brettw) common.gypi has this only for target toolset. | 106 # TODO(brettw) common.gypi has this only for target toolset. | 
| (...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 329 | 330 | 
| 330 # Clang spots more unused functions. | 331 # Clang spots more unused functions. | 
| 331 "-Wno-unused-function", | 332 "-Wno-unused-function", | 
| 332 | 333 | 
| 333 # Warns when a const char[] is converted to bool. | 334 # Warns when a const char[] is converted to bool. | 
| 334 "-Wstring-conversion", | 335 "-Wstring-conversion", | 
| 335 ] | 336 ] | 
| 336 } | 337 } | 
| 337 } | 338 } | 
| 338 } | 339 } | 
| OLD | NEW |