Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2360603002: Roll kernel to latest and add baseline test. (Closed)

Created:
4 years, 2 months ago by Johnni Winther
Modified:
4 years, 2 months ago
Reviewers:
asgerf, Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Roll kernel to latest and add baseline test. The added visitor_test tests that the IR generated by the KernelVisitor in dart2js matches the spec-mode IR. R=asgerf@google.com, het@google.com Committed: https://github.com/dart-lang/sdk/commit/7a570f1b802fe4f4b1f84fbbd0f0730c7a61cb4e

Patch Set 1 #

Total comments: 2

Patch Set 2 : dartfmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -28 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel.dart View 1 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 6 chunks +23 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 3 chunks +9 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/kernel/visitor_test.dart View 1 1 chunk +65 lines, -0 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
4 years, 2 months ago (2016-09-21 14:09:33 UTC) #2
asgerf
LGTM https://codereview.chromium.org/2360603002/diff/1/pkg/compiler/lib/src/kernel/kernel.dart File pkg/compiler/lib/src/kernel/kernel.dart (right): https://codereview.chromium.org/2360603002/diff/1/pkg/compiler/lib/src/kernel/kernel.dart#newcode213 pkg/compiler/lib/src/kernel/kernel.dart:213: for (ir.InterfaceType interface in typesToIr(cls.interfaces.reverse().toList())) { Long line.
4 years, 2 months ago (2016-09-21 15:24:01 UTC) #3
Harry Terkelsen
lgtm
4 years, 2 months ago (2016-09-21 16:28:10 UTC) #4
Johnni Winther
https://codereview.chromium.org/2360603002/diff/1/pkg/compiler/lib/src/kernel/kernel.dart File pkg/compiler/lib/src/kernel/kernel.dart (right): https://codereview.chromium.org/2360603002/diff/1/pkg/compiler/lib/src/kernel/kernel.dart#newcode213 pkg/compiler/lib/src/kernel/kernel.dart:213: for (ir.InterfaceType interface in typesToIr(cls.interfaces.reverse().toList())) { On 2016/09/21 15:24:01, ...
4 years, 2 months ago (2016-09-22 08:10:58 UTC) #5
Johnni Winther
4 years, 2 months ago (2016-09-22 08:16:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7a570f1b802fe4f4b1f84fbbd0f0730c7a61cb4e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698