Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: components/plugins.gypi

Issue 23606022: Move renderer plugin code into a new component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move renderer plugin code into a new component - reply to comments and add namespace Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/plugins.gypi
diff --git a/components/web_modal.gypi b/components/plugins.gypi
similarity index 36%
copy from components/web_modal.gypi
copy to components/plugins.gypi
index f2db7d4cb830ee920dd2c512a2207be1cb0b1577..8f76700d6435b811a94d4948e86fb361707227bf 100644
--- a/components/web_modal.gypi
+++ b/components/plugins.gypi
@@ -5,29 +5,30 @@
{
'targets': [
{
- 'target_name': 'web_modal',
+ 'target_name': 'plugins_renderer',
'type': 'static_library',
- 'include_dirs': [
- '..',
- ],
'dependencies': [
- '../base/base.gyp:base',
- '../content/content.gyp:content_browser',
'../skia/skia.gyp:skia',
+ '../third_party/re2/re2.gyp:re2',
+ '../third_party/WebKit/public/blink.gyp:blink',
],
- 'defines': [
- 'WEB_MODAL_IMPLEMENTATION',
+ 'include_dirs': [
+ '..',
],
'sources': [
- 'web_modal/native_web_contents_modal_dialog.h',
- 'web_modal/native_web_contents_modal_dialog_manager.h',
- 'web_modal/web_contents_modal_dialog_host.cc',
- 'web_modal/web_contents_modal_dialog_host.h',
- 'web_modal/web_contents_modal_dialog_manager.cc',
- 'web_modal/web_contents_modal_dialog_manager.h',
- 'web_modal/web_contents_modal_dialog_manager_delegate.cc',
- 'web_modal/web_contents_modal_dialog_manager_delegate.h',
+ 'plugins/renderer/plugin_placeholder.cc',
+ 'plugins/renderer/plugin_placeholder.h',
+ 'plugins/renderer/webview_plugin.cc',
+ 'plugins/renderer/webview_plugin.h',
+ ],
+ 'conditions' : [
+ ['OS=="android"', {
+ 'sources': [
+ 'plugins/renderer/mobile_youtube_plugin.cc',
+ 'plugins/renderer/mobile_youtube_plugin.h',
+ ]
+ }],
],
},
- ],
+ ]
}

Powered by Google App Engine
This is Rietveld 408576698