Move renderer plugin code into a new component.

components/plugins.gypi

Index: components/plugins.gypi
diff --git a/components/plugins.gypi b/components/plugins.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..1dd2b68e13b3fb0afa53be2fd3892139b2ebe56f
--- /dev/null
+++ b/components/plugins.gypi
@@ -0,0 +1,36 @@
+# Copyright (c) 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+  'targets': [
+    {
+      'target_name': 'plugins_renderer',

[darin (slow to review), 2013/10/01 17:22:59]

I find the name "plugins_renderer" a bit confusing. I think you are trying to
indicate that these are plugins that are intended to only run in the renderer
process. We typically refer to those as "in process plugins", so perhaps you
could rename this component in_process_plugins and use that as the namespace?

I'd imagine that the directory would also be changed from
components/plugins/renderer/ to components/in_process_plugins/.

Sound OK?

[aberent, 2013/10/01 18:14:55]

I originally called it just "plugins" but didn't want to leave it like that
because there is a substantial plugins module in chrome/browser that I can see
we might in future want to move to a component. 

In calling it "plugins_renderer" I believe I am following the pattern
established by the visitedlink component which has "visitedlink_browser",
"visitedlink_common" and "visitedlink_renderer", and the autofill component,
which has (among other targets) "autofill_content_browser" and
"autofill_content_renderer" 

On 2013/10/01 17:22:59, darin wrote:

+      'type': 'static_library',
+      'dependencies': [
+        '../skia/skia.gyp:skia',
+        '../third_party/re2/re2.gyp:re2',
+        '../third_party/WebKit/public/blink.gyp:blink',
+      ],
+      'include_dirs': [
+        '..',
+      ],
+      'sources': [
+        'plugins/renderer/plugin_placeholder.cc',
+        'plugins/renderer/plugin_placeholder.h',
+        # 'plugins/renderer/plugin_uma_unittest.cc',

[darin (slow to review), 2013/10/01 17:22:59]

nit: delete this commented out line?

[aberent, 2013/10/01 18:14:55]

Done. You appear to be looking at patch set 1. This has been fixed in more
recent patch sets (the current version is patch set 7).

+        'plugins/renderer/plugin_uma.cc',
+        'plugins/renderer/plugin_uma.h',
+        'plugins/renderer/webview_plugin.cc',
+        'plugins/renderer/webview_plugin.h',
+      ],
+      'conditions' : [
+        ['OS=="android"', {
+          'defines': [
+             'ENABLE_MOBILE_YOUTUBE_PLUGIN',
+          ],
+        }],
+      ],
+    },
+  ]
+}