chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h - Issue 23606016: Refactor LauncherItemController and LauncherItemDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h

Issue 23606016: Refactor LauncherItemController and LauncherItemDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix for unittest.. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc ('k') | chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h

diff --git a/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h b/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h

index 749e10129412eb43e1b910eb7a18ebeca229bab5..fbdfd970b8460273d747f895a99adc42ec92372a 100644

--- a/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h

+++ b/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h

@@ -30,17 +30,22 @@ class BrowserShortcutLauncherItemController : public LauncherItemController {

void UpdateBrowserItemState();

// LauncherItemController overrides:

- virtual string16 GetTitle() OVERRIDE;

virtual bool IsCurrentlyShownInWindow(aura::Window* window) const OVERRIDE;

virtual bool IsOpen() const OVERRIDE;

virtual bool IsVisible() const OVERRIDE;

virtual void Launch(ash::LaunchSource source, int event_flags) OVERRIDE;

virtual void Activate(ash::LaunchSource source) OVERRIDE;

virtual void Close() OVERRIDE;

- virtual void Clicked(const ui::Event& event) OVERRIDE;

- virtual void OnRemoved() OVERRIDE;

virtual ChromeLauncherAppMenuItems GetApplicationList(

int event_flags) OVERRIDE;

+ virtual void ItemSelected(const ui::Event& event) OVERRIDE;

+ virtual base::string16 GetTitle() OVERRIDE;

+ virtual ui::MenuModel* CreateContextMenu(

+ aura::RootWindow* root_window) OVERRIDE;

+ virtual ash::LauncherMenuModel* CreateApplicationMenu(

+ int event_flags) OVERRIDE;

+ virtual bool IsDraggable() OVERRIDE;

+ virtual bool ShouldShowTooltip() OVERRIDE;

private:

// Get the favicon for the browser list entry for |web_contents|.