Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.h

Issue 23606016: Refactor LauncherItemController and LauncherItemDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix for unittest.. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_SHELL_WINDOW_LAUNCHER_ITEM_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_SHELL_WINDOW_LAUNCHER_ITEM_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_ASH_LAUNCHER_SHELL_WINDOW_LAUNCHER_ITEM_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_ASH_LAUNCHER_SHELL_WINDOW_LAUNCHER_ITEM_CONTROLLER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <string> 9 #include <string>
10 10
(...skipping 13 matching lines...) Expand all
24 namespace gfx { 24 namespace gfx {
25 class Image; 25 class Image;
26 } 26 }
27 27
28 class ChromeLauncherController; 28 class ChromeLauncherController;
29 29
30 // This is a ShellWindowItemLauncherController for shell windows. There is one 30 // This is a ShellWindowItemLauncherController for shell windows. There is one
31 // instance per app, per launcher id. 31 // instance per app, per launcher id.
32 // For apps with multiple windows, each item controller keeps track of all 32 // For apps with multiple windows, each item controller keeps track of all
33 // windows associated with the app and their activation order. 33 // windows associated with the app and their activation order.
34 // Instances are owned by ShellWindowLauncherController. 34 // Instances are owned by ash::LauncherItemDelegateManager.
35 // 35 //
36 // Tests are in chrome_launcher_controller_browsertest.cc 36 // Tests are in chrome_launcher_controller_browsertest.cc
37 37
38 class ShellWindowLauncherItemController : public LauncherItemController, 38 class ShellWindowLauncherItemController : public LauncherItemController,
39 public aura::WindowObserver { 39 public aura::WindowObserver {
40 public: 40 public:
41 ShellWindowLauncherItemController(Type type, 41 ShellWindowLauncherItemController(Type type,
42 const std::string& app_launcher_id, 42 const std::string& app_launcher_id,
43 const std::string& app_id, 43 const std::string& app_id,
44 ChromeLauncherController* controller); 44 ChromeLauncherController* controller);
45 45
46 virtual ~ShellWindowLauncherItemController(); 46 virtual ~ShellWindowLauncherItemController();
47 47
48 void AddShellWindow(apps::ShellWindow* shell_window, 48 void AddShellWindow(apps::ShellWindow* shell_window,
49 ash::LauncherItemStatus status); 49 ash::LauncherItemStatus status);
50 50
51 void RemoveShellWindowForWindow(aura::Window* window); 51 void RemoveShellWindowForWindow(aura::Window* window);
52 52
53 void SetActiveWindow(aura::Window* window); 53 void SetActiveWindow(aura::Window* window);
54 54
55 const std::string& app_launcher_id() const { return app_launcher_id_; } 55 const std::string& app_launcher_id() const { return app_launcher_id_; }
56 56
57 // LauncherItemController 57 // LauncherItemController overrides:
58 virtual string16 GetTitle() OVERRIDE;
59 virtual bool IsCurrentlyShownInWindow(aura::Window* window) const OVERRIDE; 58 virtual bool IsCurrentlyShownInWindow(aura::Window* window) const OVERRIDE;
60 virtual bool IsOpen() const OVERRIDE; 59 virtual bool IsOpen() const OVERRIDE;
61 virtual bool IsVisible() const OVERRIDE; 60 virtual bool IsVisible() const OVERRIDE;
62 virtual void Launch(ash::LaunchSource source, int event_flags) OVERRIDE; 61 virtual void Launch(ash::LaunchSource source, int event_flags) OVERRIDE;
63 virtual void Activate(ash::LaunchSource source) OVERRIDE; 62 virtual void Activate(ash::LaunchSource source) OVERRIDE;
64 virtual void Close() OVERRIDE; 63 virtual void Close() OVERRIDE;
65 virtual void Clicked(const ui::Event& event) OVERRIDE;
66 virtual void OnRemoved() OVERRIDE {}
67 virtual ChromeLauncherAppMenuItems GetApplicationList( 64 virtual ChromeLauncherAppMenuItems GetApplicationList(
68 int event_flags) OVERRIDE; 65 int event_flags) OVERRIDE;
66 virtual void ItemSelected(const ui::Event& eent) OVERRIDE;
67 virtual base::string16 GetTitle() OVERRIDE;
68 virtual ui::MenuModel* CreateContextMenu(
69 aura::RootWindow* root_window) OVERRIDE;
70 virtual ash::LauncherMenuModel* CreateApplicationMenu(
71 int event_flags) OVERRIDE;
72 virtual bool IsDraggable() OVERRIDE;
73 virtual bool ShouldShowTooltip() OVERRIDE;
69 74
70 // aura::WindowObserver 75 // aura::WindowObserver overrides:
71 virtual void OnWindowPropertyChanged(aura::Window* window, 76 virtual void OnWindowPropertyChanged(aura::Window* window,
72 const void* key, 77 const void* key,
73 intptr_t old) OVERRIDE; 78 intptr_t old) OVERRIDE;
74 79
75 // Get the number of running applications/incarnations of this. 80 // Get the number of running applications/incarnations of this.
76 size_t shell_window_count() const { return shell_windows_.size(); } 81 size_t shell_window_count() const { return shell_windows_.size(); }
77 82
78 // Activates the window at position |index|. 83 // Activates the window at position |index|.
79 void ActivateIndexedApp(size_t index); 84 void ActivateIndexedApp(size_t index);
80 85
(...skipping 16 matching lines...) Expand all
97 // AppLauncherItemController for each |app_launcher_id_|. 102 // AppLauncherItemController for each |app_launcher_id_|.
98 const std::string app_launcher_id_; 103 const std::string app_launcher_id_;
99 104
100 // Scoped list of observed windows (for removal on destruction) 105 // Scoped list of observed windows (for removal on destruction)
101 ScopedObserver<aura::Window, aura::WindowObserver> observed_windows_; 106 ScopedObserver<aura::Window, aura::WindowObserver> observed_windows_;
102 107
103 DISALLOW_COPY_AND_ASSIGN(ShellWindowLauncherItemController); 108 DISALLOW_COPY_AND_ASSIGN(ShellWindowLauncherItemController);
104 }; 109 };
105 110
106 #endif // CHROME_BROWSER_UI_ASH_LAUNCHER_SHELL_WINDOW_LAUNCHER_ITEM_CONTROLLER_ H_ 111 #endif // CHROME_BROWSER_UI_ASH_LAUNCHER_SHELL_WINDOW_LAUNCHER_ITEM_CONTROLLER_ H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698