Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: ash/launcher/launcher_item_delegate_manager.h

Issue 23606016: Refactor LauncherItemController and LauncherItemDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix for unittest.. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/launcher/launcher_item_delegate.h ('k') | ash/launcher/launcher_item_delegate_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_LAUNCHER_LAUNCHER_ITEM_DELEGATE_MANAGER_H_ 5 #ifndef ASH_LAUNCHER_LAUNCHER_ITEM_DELEGATE_MANAGER_H_
6 #define ASH_LAUNCHER_LAUNCHER_ITEM_DELEGATE_MANAGER_H_ 6 #define ASH_LAUNCHER_LAUNCHER_ITEM_DELEGATE_MANAGER_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "ash/ash_export.h" 10 #include "ash/ash_export.h"
11 #include "ash/launcher/launcher_model_observer.h"
11 #include "ash/launcher/launcher_types.h" 12 #include "ash/launcher/launcher_types.h"
12 #include "base/compiler_specific.h" 13 #include "base/compiler_specific.h"
14 #include "base/memory/scoped_ptr.h"
13 15
14 namespace ash { 16 namespace ash {
15 class LauncherItemDelegate; 17 class LauncherItemDelegate;
18 class LauncherModel;
16 19
17 // LauncherItemDelegateManager helps Launcher/LauncherView to choose right 20 namespace test {
18 // LauncherItemDelegate based on LauncherItemType. 21 class LauncherItemDelegateManagerTestAPI;
19 // When new LauncherItemDelegate is created, it must be registered by 22 }
20 // RegisterLauncherItemDelegate(). If not, Launcher/LauncherView can't get 23
21 // LauncherItem's LauncherItemDelegate. 24 // LauncherItemDelegateManager manages the set of LauncherItemDelegates for the
22 // TODO(simon.hong81): This class should own all LauncherItemDelegate. 25 // launcher. LauncherItemDelegateManager does not create LauncherItemDelegates,
23 class ASH_EXPORT LauncherItemDelegateManager { 26 // rather it is expected that someone else invokes SetLauncherItemDelegate
27 // appropriately. On the other hand, LauncherItemDelegateManager destroys
28 // LauncherItemDelegates when the corresponding item from the model is removed.
29 class ASH_EXPORT LauncherItemDelegateManager
30 : public ash::LauncherModelObserver {
24 public: 31 public:
25 LauncherItemDelegateManager(); 32 explicit LauncherItemDelegateManager(ash::LauncherModel* model);
26 virtual ~LauncherItemDelegateManager(); 33 virtual ~LauncherItemDelegateManager();
27 34
28 // Returns LauncherItemDelegate for |item_type|. 35 // Set |item_delegate| for |id| and take an ownership.
29 // This class doesn't own each LauncherItemDelegate for now. 36 void SetLauncherItemDelegate(
30 LauncherItemDelegate* GetLauncherItemDelegate( 37 ash::LauncherID id,
31 ash::LauncherItemType item_type); 38 scoped_ptr<ash::LauncherItemDelegate> item_delegate);
32 39
33 // Register |item_delegate| for |type|. 40 // Returns LauncherItemDelegate for |item_type|. Always returns non-NULL.
34 // For now, This class doesn't own |item_delegate|. 41 LauncherItemDelegate* GetLauncherItemDelegate(ash::LauncherID id);
35 // TODO(simon.hong81): Register LauncherItemDelegate with LauncherID. 42
36 void RegisterLauncherItemDelegate( 43 // ash::LauncherModelObserver overrides:
37 ash::LauncherItemType type, LauncherItemDelegate* item_delegate); 44 virtual void LauncherItemAdded(int model_index) OVERRIDE;
45 virtual void LauncherItemRemoved(int index, ash::LauncherID id) OVERRIDE;
46 virtual void LauncherItemMoved(int start_index, int targetindex) OVERRIDE;
47 virtual void LauncherItemChanged(
48 int index,
49 const ash::LauncherItem& old_item) OVERRIDE;
50 virtual void LauncherStatusChanged() OVERRIDE;
38 51
39 private: 52 private:
40 typedef std::map<ash::LauncherItemType, LauncherItemDelegate*> 53 friend class ash::test::LauncherItemDelegateManagerTestAPI;
41 LauncherItemTypeToItemDelegateMap;
42 54
43 LauncherItemTypeToItemDelegateMap item_type_to_item_delegate_map_; 55 typedef std::map<ash::LauncherID, LauncherItemDelegate*>
56 LauncherIDToItemDelegateMap;
57
58 // Remove and destroy LauncherItemDelegate for |id|.
59 void RemoveLauncherItemDelegate(ash::LauncherID id);
60
61 // Clear all exsiting LauncherItemDelegate for test.
62 // Not owned by LauncherItemDelegate.
63 ash::LauncherModel* model_;
64
65 LauncherIDToItemDelegateMap id_to_item_delegate_map_;
44 66
45 DISALLOW_COPY_AND_ASSIGN(LauncherItemDelegateManager); 67 DISALLOW_COPY_AND_ASSIGN(LauncherItemDelegateManager);
46 }; 68 };
47 69
48 } // namespace ash 70 } // namespace ash
49 71
50 #endif // ASH_LAUNCHER_LAUNCHER_ITEM_DELEGATE_MANAGER_H_ 72 #endif // ASH_LAUNCHER_LAUNCHER_ITEM_DELEGATE_MANAGER_H_
OLDNEW
« no previous file with comments | « ash/launcher/launcher_item_delegate.h ('k') | ash/launcher/launcher_item_delegate_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698