Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 23606012: remove Isolate::Current from most files starting with 'd' and 'e' (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

remove Isolate::Current from most files starting with 'd' and 'e' R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16490

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -143 lines) Patch
M src/accessors.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/api.cc View 18 chunks +20 lines, -20 lines 0 comments Download
M src/d8.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug.h View 5 chunks +7 lines, -4 lines 0 comments Download
M src/debug.cc View 27 chunks +33 lines, -33 lines 0 comments Download
M src/debug-agent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/disassembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/execution.h View 4 chunks +28 lines, -15 lines 0 comments Download
M src/execution.cc View 14 chunks +35 lines, -33 lines 2 comments Download
M src/factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/json-stringifier.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime.cc View 18 chunks +26 lines, -20 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcarney
7 years, 3 months ago (2013-09-02 13:23:34 UTC) #1
Sven Panne
LGTM with a nit. https://codereview.chromium.org/23606012/diff/1/src/execution.cc File src/execution.cc (right): https://codereview.chromium.org/23606012/diff/1/src/execution.cc#newcode159 src/execution.cc:159: Isolate* isolate = Isolate::Current(); I ...
7 years, 3 months ago (2013-09-02 14:23:45 UTC) #2
dcarney
https://codereview.chromium.org/23606012/diff/1/src/execution.cc File src/execution.cc (right): https://codereview.chromium.org/23606012/diff/1/src/execution.cc#newcode159 src/execution.cc:159: Isolate* isolate = Isolate::Current(); On 2013/09/02 14:23:45, Sven Panne ...
7 years, 3 months ago (2013-09-02 15:38:43 UTC) #3
dcarney
7 years, 3 months ago (2013-09-03 06:59:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r16490 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698