Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2360593002: Widen Mac expectations for move_backward_line_import_crash.html (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Widen Mac expectations for move_backward_line_import_crash.html editing/selection/modify_move/move_backward_line_import_crash.html appears to also Crash on Mac Debug. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/4772 TBR=xiaochengh@chromium.org BUG=648547, 646323 NOTRY=true Committed: https://crrev.com/62e3d20e14e91f3999e3ec92fc9f706f9b29d21b Cr-Commit-Position: refs/heads/master@{#420040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360593002/1
4 years, 3 months ago (2016-09-21 13:43:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 13:48:21 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/62e3d20e14e91f3999e3ec92fc9f706f9b29d21b Cr-Commit-Position: refs/heads/master@{#420040}
4 years, 3 months ago (2016-09-21 13:52:14 UTC) #7
ymalik
On 2016/09/21 13:52:14, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 3 months ago (2016-09-21 16:05:57 UTC) #8
Xiaocheng
4 years, 3 months ago (2016-09-22 06:15:22 UTC) #9
Message was sent while issue was closed.
On 2016/09/21 at 16:05:57, ymalik wrote:
> On 2016/09/21 13:52:14, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/62e3d20e14e91f3999e3ec92fc9f706f9b29d21b
> > Cr-Commit-Position: refs/heads/master@{#420040}
> 
> I suspect this is caused by https://codereview.chromium.org/2354893002
> 
> xiaocheng, can you investigate and remove this expectation if it makes sense?

https://codereview.chromium.org/2354893002 shouldn't be related, or at least
I'll be surprised if it is...

I tried to open your revert CL https://codereview.chromium.org/2357143003/, but
it says "no issue exists with that id". I guess the revert is not landed, is it?

The build bot
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20(dbg)
is also working normally now.

Powered by Google App Engine
This is Rietveld 408576698