Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2360573002: Fix memory leaks reported by clang static analyzer. (Closed)

Created:
4 years, 3 months ago by sdefresne
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix memory leaks reported by clang static analyzer. The CFURLCopyFileSystemPath & CFURLCopyFileSystemPath methods respect the "Create Rule" [1] regarding the ownership of the returned reference. This means that the objects need to be deallocated explicitly by calling CFRelease. [1]: https://developer.apple.com/library/content/documentation/CoreFoundation/Conceptual/CFMemoryMgmt/Concepts/Ownership.html#//apple_ref/doc/uid/20001148-103029 BUG=648210 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360573002 Committed: https://skia.googlesource.com/skia/+/67ba29ce84c464270e8f4ccca6c22d37882a90f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/ports/SkOSFile_stdio.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
sdefresne
Please take a look. If this looks similar to the CL from yesterday, this is ...
4 years, 3 months ago (2016-09-21 13:10:24 UTC) #5
bsalomon
lgtm
4 years, 3 months ago (2016-09-21 13:23:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360573002/1
4 years, 3 months ago (2016-09-21 13:50:43 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 13:51:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/67ba29ce84c464270e8f4ccca6c22d37882a90f4

Powered by Google App Engine
This is Rietveld 408576698