Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2360563002: MacViews: Fix browser_tests compilation. (Closed)

Created:
4 years, 3 months ago by themblsha
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Fix browser_tests compilation. Aura is not supported on macOS, even with mac_views_browser_enabled. Committed: https://crrev.com/631e8382bc4929eab489ce0a1bb7937fc5b2d557 Cr-Commit-Position: refs/heads/master@{#420114}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
themblsha
MacViews doesn't build tests on the bots? Should be very easily detectable.
4 years, 3 months ago (2016-09-21 12:34:14 UTC) #2
sky
LGTM
4 years, 3 months ago (2016-09-21 16:09:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360563002/1
4 years, 3 months ago (2016-09-21 17:35:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 18:36:43 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 18:39:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/631e8382bc4929eab489ce0a1bb7937fc5b2d557
Cr-Commit-Position: refs/heads/master@{#420114}

Powered by Google App Engine
This is Rietveld 408576698