Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2360473002: Add hardware monitoring to skpbench (Closed)

Created:
4 years, 3 months ago by csmartdalton
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add hardware monitoring to skpbench Adds a Hardware class with hooks for entering and exiting "benchmarking" mode (e.g. locking clocks, etc.) as well as periodic polling of hardware to verify the environment is stable. Adds a partial implementation for generic Android hardware, but ultimately we will need to write specific classes tailored to each unique platform we need to test. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360473002 Committed: https://skia.googlesource.com/skia/+/d7a9db644496785100c4e61add1c9f8ed0494408

Patch Set 1 #

Patch Set 2 : Add hardware monitoring to skpbench #

Patch Set 3 : Add hardware monitoring to skpbench #

Patch Set 4 : Add hardware monitoring to skpbench #

Patch Set 5 : Add hardware monitoring to skpbench #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -107 lines) Patch
M tools/skpbench/_adb.py View 1 chunk +34 lines, -12 lines 0 comments Download
M tools/skpbench/_adb_path.py View 2 chunks +8 lines, -9 lines 0 comments Download
A tools/skpbench/_hardware.py View 1 2 3 4 1 chunk +29 lines, -0 lines 0 comments Download
A tools/skpbench/_hardware_android.py View 1 2 3 4 1 chunk +93 lines, -0 lines 0 comments Download
M tools/skpbench/parseskpbench.py View 1 2 3 4 4 chunks +12 lines, -12 lines 0 comments Download
M tools/skpbench/skpbench.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M tools/skpbench/skpbench.py View 1 2 3 4 3 chunks +151 lines, -69 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
csmartdalton
4 years, 3 months ago (2016-09-21 04:42:04 UTC) #3
bsalomon
rubberstamp lgtm
4 years, 3 months ago (2016-09-21 13:32:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360473002/80001
4 years, 3 months ago (2016-09-21 19:16:59 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 12:10:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/d7a9db644496785100c4e61add1c9f8ed0494408

Powered by Google App Engine
This is Rietveld 408576698