[Chromecast] Add CastMediaBlocker and BrowserTest

[Chromecast] Add CastMediaBlocker and BrowserTest

CastMediaBlocker is a class which can prevent media from being played
on a web page.

This CL relands 502bcc946bd12e907572f8b22ef4a0abbc8190d0

BUG=NONE
TEST=ChromecastShellMediaBlockingBrowserTest

Committed: https://crrev.com/b7502d797b1f1ff92ac2d44a0b22c44c2091d3f3
Cr-Commit-Position: refs/heads/master@{#420514}

[derekjchow1, 2016-09-21 17:01:49]

The CQ bit was checked by derekjchow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 17:03:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 18:44:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 18:45:00]

Dry run: This issue passed the CQ dry run.

[derekjchow1, 2016-09-21 18:52:36]

derekjchow@chromium.org changed reviewers:
+ alokp@chromium.org, byungchul@chromium.org, halliwell@chromium.org

[derekjchow1, 2016-09-21 18:52:37]

This CL relands CastMediaBlocker.

Patchset 1 is just a straight reland of 2330243002

Patchset 2 Adds a loop to player.html, which prevents the media element from
stopping with our dummy default CMA pipeline. This should keep the integration
tests green. Thanks to alokp@ for the suggestion!

Patchset 3 includes fixes for internal b/31502572

[alokp, 2016-09-21 20:51:19]

alokp@chromium.org changed reviewers:
+ xhwang@chromium.org

[alokp, 2016-09-21 20:51:20]

+xhwang to review media/

https://codereview.chromium.org/2360443002/diff/40001/chromecast/browser/cast...
File chromecast/browser/cast_media_blocker.h (right):

https://codereview.chromium.org/2360443002/diff/40001/chromecast/browser/cast...
chromecast/browser/cast_media_blocker.h:27: void BlockMediaLoading(bool
blocked);
Document the default state.

https://codereview.chromium.org/2360443002/diff/40001/chromecast/browser/test...
File chromecast/browser/test/chromecast_shell_media_blocking_browser_test.cc
(right):

https://codereview.chromium.org/2360443002/diff/40001/chromecast/browser/test...
chromecast/browser/test/chromecast_shell_media_blocking_browser_test.cc:85: #if
!BUILDFLAG(IS_CAST_AUDIO_ONLY)
Can you try removing this guard? Audio devices should be able simply ignore the
video stream. You may do it in a later patch.

[alokp, 2016-09-21 20:51:37]

chromecast/ lgtm

[xhwang, 2016-09-21 21:33:19]

https://codereview.chromium.org/2360443002/diff/40001/media/test/data/player....
File media/test/data/player.html (right):

https://codereview.chromium.org/2360443002/diff/40001/media/test/data/player....
media/test/data/player.html:75: }
Could you please update the comment above this function to include the new
features you are adding?

[derekjchow1, 2016-09-21 22:06:13]

https://codereview.chromium.org/2360443002/diff/40001/chromecast/browser/cast...
File chromecast/browser/cast_media_blocker.h (right):

https://codereview.chromium.org/2360443002/diff/40001/chromecast/browser/cast...
chromecast/browser/cast_media_blocker.h:27: void BlockMediaLoading(bool
blocked);
On 2016/09/21 20:51:20, alokp wrote:
> Document the default state.

Done.

https://codereview.chromium.org/2360443002/diff/40001/chromecast/browser/test...
File chromecast/browser/test/chromecast_shell_media_blocking_browser_test.cc
(right):

https://codereview.chromium.org/2360443002/diff/40001/chromecast/browser/test...
chromecast/browser/test/chromecast_shell_media_blocking_browser_test.cc:85: #if
!BUILDFLAG(IS_CAST_AUDIO_ONLY)
On 2016/09/21 20:51:20, alokp wrote:
> Can you try removing this guard? Audio devices should be able simply ignore
the
> video stream. You may do it in a later patch.

Will do in another patch (also for other browser tests).

https://codereview.chromium.org/2360443002/diff/40001/media/test/data/player....
File media/test/data/player.html (right):

https://codereview.chromium.org/2360443002/diff/40001/media/test/data/player....
media/test/data/player.html:75: }
On 2016/09/21 21:33:18, xhwang (slow) wrote:
> Could you please update the comment above this function to include the new
> features you are adding?

Done.

[byungchul, 2016-09-21 22:14:22]

lgtm

[xhwang, 2016-09-21 22:37:41]

https://codereview.chromium.org/2360443002/diff/60001/media/test/data/player....
File media/test/data/player.html (right):

https://codereview.chromium.org/2360443002/diff/60001/media/test/data/player....
media/test/data/player.html:47: // the created audio element to loop.
Can you actually expand the "extra_params" since we only have one? It'll be nice
that someone can use this without looking into the implementation details.

Also, if we use 'video' and 'loop', what will happen?

[derekjchow1, 2016-09-22 20:32:44]

https://codereview.chromium.org/2360443002/diff/60001/media/test/data/player....
File media/test/data/player.html (right):

https://codereview.chromium.org/2360443002/diff/60001/media/test/data/player....
media/test/data/player.html:47: // the created audio element to loop.
On 2016/09/21 22:37:41, xhwang (slow) wrote:
> Can you actually expand the "extra_params" since we only have one? It'll be
nice
> that someone can use this without looking into the implementation details.
> 
> Also, if we use 'video' and 'loop', what will happen?

Added loop in explicitly and changed the "audio" element to be a "media"
element. Both types should loop.

[xhwang, 2016-09-22 21:42:38]

lgtm with last nit

https://codereview.chromium.org/2360443002/diff/80001/media/test/data/player....
File media/test/data/player.html (right):

https://codereview.chromium.org/2360443002/diff/80001/media/test/data/player....
media/test/data/player.html:42: //
"player.html?[tag]=[media_url](&loop=[true/false])".
nit: typically we use [] for optional parameters. Here "loop" is optional and
"tag" is mandatory...

[derekjchow1, 2016-09-22 23:00:01]

https://codereview.chromium.org/2360443002/diff/80001/media/test/data/player....
File media/test/data/player.html (right):

https://codereview.chromium.org/2360443002/diff/80001/media/test/data/player....
media/test/data/player.html:42: //
"player.html?[tag]=[media_url](&loop=[true/false])".
On 2016/09/22 21:42:37, xhwang (slow) wrote:
> nit: typically we use [] for optional parameters. Here "loop" is optional and
> "tag" is mandatory...

Done.

[derekjchow1, 2016-09-22 23:00:05]

The CQ bit was checked by derekjchow@chromium.org

[derekjchow1, 2016-09-22 23:00:05]

The patchset sent to the CQ was uploaded after l-g-t-m from alokp@chromium.org,
byungchul@chromium.org, xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2360443002/#ps100001
(title: "use [] for optional query param")

[commit-bot: I haz the power, 2016-09-22 23:00:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 00:56:42]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-23 01:00:18]

Description was changed from

==========
[Chromecast] Add CastMediaBlocker and BrowserTest

CastMediaBlocker is a class which can prevent media from being played
on a web page.

This CL relands 502bcc946bd12e907572f8b22ef4a0abbc8190d0

BUG=NONE
TEST=ChromecastShellMediaBlockingBrowserTest
==========

to

==========
[Chromecast] Add CastMediaBlocker and BrowserTest

CastMediaBlocker is a class which can prevent media from being played
on a web page.

This CL relands 502bcc946bd12e907572f8b22ef4a0abbc8190d0

BUG=NONE
TEST=ChromecastShellMediaBlockingBrowserTest

Committed: https://crrev.com/b7502d797b1f1ff92ac2d44a0b22c44c2091d3f3
Cr-Commit-Position: refs/heads/master@{#420514}
==========

[commit-bot: I haz the power, 2016-09-23 01:00:20]

Patchset 6 (id:??) landed as
https://crrev.com/b7502d797b1f1ff92ac2d44a0b22c44c2091d3f3
Cr-Commit-Position: refs/heads/master@{#420514}