Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: android_webview/browser/surfaces_instance.cc

Issue 2360423003: aw: Fix FBO restore in webview functor (Closed)
Patch Set: more code removal Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/surfaces_instance.cc
diff --git a/android_webview/browser/surfaces_instance.cc b/android_webview/browser/surfaces_instance.cc
index 0c856ddb13e05811a9801ad9fcb0ae36ca04ea88..8afa3bebe7b46815cb918d9a0312a581bf71ed67 100644
--- a/android_webview/browser/surfaces_instance.cc
+++ b/android_webview/browser/surfaces_instance.cc
@@ -39,7 +39,7 @@ scoped_refptr<SurfacesInstance> SurfacesInstance::GetOrCreateInstance() {
}
SurfacesInstance::SurfacesInstance()
- : next_surface_client_id_(1u), gl_surface_(new AwGLSurface) {
+ : next_surface_client_id_(1u) {
cc::RendererSettings settings;
// Should be kept in sync with compositor_impl_android.cc.
@@ -60,7 +60,8 @@ SurfacesInstance::SurfacesInstance()
new cc::TextureMailboxDeleter(nullptr));
std::unique_ptr<ParentOutputSurface> output_surface_holder(
new ParentOutputSurface(AwRenderThreadContextProvider::Create(
- gl_surface_, DeferredGpuCommandService::GetInstance())));
+ make_scoped_refptr(new AwGLSurface),
+ DeferredGpuCommandService::GetInstance())));
output_surface_ = output_surface_holder.get();
std::unique_ptr<cc::DisplayScheduler> scheduler(new cc::DisplayScheduler(
begin_frame_source.get(), nullptr,
@@ -101,11 +102,6 @@ cc::SurfaceManager* SurfacesInstance::GetSurfaceManager() {
return surface_manager_.get();
}
-void SurfacesInstance::SetBackingFrameBufferObject(
- int framebuffer_binding_ext) {
- gl_surface_->SetBackingFrameBufferObject(framebuffer_binding_ext);
-}
-
void SurfacesInstance::DrawAndSwap(const gfx::Size& viewport,
const gfx::Rect& clip,
const gfx::Transform& transform,

Powered by Google App Engine
This is Rietveld 408576698