third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h - Issue 2360413002: Implement OffscreenCanvas Unaccelerated 2d commit() on main thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

Issue 2360413002: Implement OffscreenCanvas Unaccelerated 2d commit() on main thread (Closed)

Patch Set: Address all feedback Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/test/gpu/page_sets/pixel_tests.py ('K') | « content/test/gpu/page_sets/pixel_tests.py ('k') | third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp » ('j') | third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

diff --git a/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

index 52384bb356bd6bf02879d2079d66b16489dd8e4e..97bc78539f40efe586a01dc03e2af8f102337195 100644

--- a/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

+++ b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

@@ -6,6 +6,7 @@

#define OffscreenCanvasFrameDispatcherImpl_h

#include "cc/ipc/mojo_compositor_frame_sink.mojom-blink.h"

+#include "cc/resources/shared_bitmap.h"

#include "cc/surfaces/surface_id.h"

#include "mojo/public/cpp/bindings/binding.h"

#include "platform/graphics/OffscreenCanvasFrameDispatcher.h"

@@ -33,7 +34,9 @@ private:

const int m_height;

unsigned m_nextResourceId;

+ unsigned getNextResourceIdAndIncrement() { return m_nextResourceId++; }

HashMap<unsigned, RefPtr<StaticBitmapImage>> m_cachedImages;

+ HashMap<unsigned, std::unique_ptr<cc::SharedBitmap>> m_sharedBitmaps;

bool verifyImageSize(const sk_sp<SkImage>&);