Implement OffscreenCanvas Unaccelerated 2d commit() on main thread

content/test/gpu/gpu_tests/pixel_test_pages.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 class PixelTestPage(object):
   """A wrapper class mimicking the functionality of the PixelTestsStorySet
   from the old-style GPU tests.
   """
   def __init__(self, url, name, test_rect, revision,
                expected_colors=None, tolerance=2, browser_args=None):
@@ skipping 146 matching lines @@
       browser_args=browser_args),
 
     PixelTestPage(
       'pixel_offscreenCanvas_webgl_commit_worker.html',
       base_name + '_OffscreenCanvasWebGLRedBoxWorker',
       test_rect=[0, 0, 300, 300],
       revision=3,
       browser_args=browser_args),
 
     PixelTestPage(
-      'pixel_acceleratedOffscreen2d_commit_main.html',
+      'pixel_offscreenCanvas_2d_commit_main.html',
       base_name + '_OffscreenCanvasAccelerated2D',
       test_rect=[0, 0, 350, 350],
       revision=1,
       browser_args=browser_args),
 
     PixelTestPage(
-      'pixel_acceleratedOffscreen2d_commit_worker.html',
+      'pixel_offscreenCanvas_2d_commit_worker.html',
       base_name + '_OffscreenCanvasAccelerated2DWorker',
       test_rect=[0, 0, 350, 350],
       revision=1,
       browser_args=browser_args),
   ]
 
+# Pages that should be run with software compositing path and
+# experimental canvas features
+def SoftwareOffscreenCanvas2dPages(base_name):
+  browser_args = [
+    '--enable-experimental-canvas-features',
+    '--disable-accelerated-2d-canvas',
+    '--disable-gpu-compositing']
+
+  return [
+    PixelTestPage(

[Ken Russell (switch to Gerrit), 2016/09/30 20:00:45]

Could you just add this to the above ExperimentalCanvasFeaturesPages set, above?
You can just say:

  browser_args = browser_args + [
    '--disable-accelerated-2d-canvas',
    '--disable-gpu-compositing']

That way you don't need to touch pixel_integration_test at all.

+      'pixel_offscreenCanvas_2d_commit_main.html',
+      base_name + '_OffscreenCanvasUnaccelerated2D',
+      test_rect=[0, 0, 350, 350],
+      revision=1,
+      browser_args=browser_args),
+    ]
+
 # Pages that should be run with various macOS specific command line
 # arguments.
 def MacSpecificPages(base_name):
   iosurface_2d_canvas_args = [
     '--enable-accelerated-2d-canvas',
     '--disable-display-list-2d-canvas']
 
   non_chromium_image_args = ['--disable-webgl-image-chromium']
 
   return [
@@ skipping 44 matching lines @@
       test_rect=[0, 0, 300, 300],
       revision=2),
     PixelTestPage(
       'filter_effects.html',
       base_name + '_CSSFilterEffects_NoOverlays',
       test_rect=[0, 0, 300, 300],
       revision=2,
       tolerance=10,
       browser_args=['--disable-mac-overlays']),
   ]