Build with API level 18 on Android.

Build with API level 18 on Android.

BUG=294699
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226343

[Joao da Silva, 2013-09-19 13:49:18]

PTAL. All targets built fine on my local checkout, let's see how it goes on the
bots.

Can you suggest a reviewer for android_webview?

[Joao da Silva, 2013-09-19 14:32:01]

https://codereview.chromium.org/23604064/diff/1/build/android/envsetup_functi...
File build/android/envsetup_functions.sh (right):

https://codereview.chromium.org/23604064/diff/1/build/android/envsetup_functi...
build/android/envsetup_functions.sh:282: export ANDROID_SDK_VERSION=18
So this breaks the AOSP build. Seems like the 'master' branch from prebuilts
doesn't have 18 yet, but 'jb-mr2-release' does.

https://android.googlesource.com/platform/prebuilts/sdk/+/master
https://android.googlesource.com/platform/prebuilts/sdk/+/jb-mr2-release

Do we have to roll the AOSP master branch first? Or update some DEPS file to use
the JB commit?

[mkosiba (inactive), 2013-09-19 17:07:17]

On 2013/09/19 14:32:01, Joao da Silva wrote:
>
https://codereview.chromium.org/23604064/diff/1/build/android/envsetup_functi...
> File build/android/envsetup_functions.sh (right):
> 
>
https://codereview.chromium.org/23604064/diff/1/build/android/envsetup_functi...
> build/android/envsetup_functions.sh:282: export ANDROID_SDK_VERSION=18
> So this breaks the AOSP build. Seems like the 'master' branch from prebuilts
> doesn't have 18 yet, but 'jb-mr2-release' does.
> 
> https://android.googlesource.com/platform/prebuilts/sdk/+/master
> https://android.googlesource.com/platform/prebuilts/sdk/+/jb-mr2-release
> 
> Do we have to roll the AOSP master branch first? Or update some DEPS file to
use
> the JB commit?

The AOSP bot checks out the android-4.3_r2.1 branch (see
https://codereview.chromium.org/22852002/)
and that surprisingly doesn't have 18, however android-4.3_r2.2 does.... I can
move the bot to
a newer tag but I'll ask around a bit before I do that.

[Joao da Silva, 2013-09-19 17:11:59]

On 2013/09/19 17:07:17, mkosiba wrote:
> On 2013/09/19 14:32:01, Joao da Silva wrote:
> >
>
https://codereview.chromium.org/23604064/diff/1/build/android/envsetup_functi...
> > File build/android/envsetup_functions.sh (right):
> > 
> >
>
https://codereview.chromium.org/23604064/diff/1/build/android/envsetup_functi...
> > build/android/envsetup_functions.sh:282: export ANDROID_SDK_VERSION=18
> > So this breaks the AOSP build. Seems like the 'master' branch from prebuilts
> > doesn't have 18 yet, but 'jb-mr2-release' does.
> > 
> > https://android.googlesource.com/platform/prebuilts/sdk/+/master
> > https://android.googlesource.com/platform/prebuilts/sdk/+/jb-mr2-release
> > 
> > Do we have to roll the AOSP master branch first? Or update some DEPS file to
> use
> > the JB commit?
> 
> The AOSP bot checks out the android-4.3_r2.1 branch (see
> https://codereview.chromium.org/22852002/)
> and that surprisingly doesn't have 18, however android-4.3_r2.2 does.... I can
> move the bot to
> a newer tag but I'll ask around a bit before I do that.

Thanks for chiming in! It'd be great if you could roll that on the bots, yea :-)

[mkosiba (inactive), 2013-09-19 17:18:41]

https://codereview.chromium.org/23503077/ has the AOSP bot version bump but I
have to build locally to check it won't blow up the bots. That usually takes a
couple of hours so please be patient.

Also, LGTM for android_webview/

[Yaron, 2013-09-19 18:07:09]

lgtm % sync test and fixing aosp. It's probably a flake but please take a look

[mkosiba (inactive), 2013-09-20 01:12:36]

The AOSP bots have been updated to a newer Android branch.

[Joao da Silva, 2013-09-20 09:43:15]

It's all green now. I'll land after the branch.

[Yaron, 2013-10-01 12:55:32]

On 2013/09/20 09:43:15, Joao da Silva wrote:
> It's all green now. I'll land after the branch.

reminder about this. I think we're good to go now. :)

[Joao da Silva, 2013-10-01 13:01:04]

> reminder about this. I think we're good to go now. :)

Great! There were no conflicts rebasing so the new patch should be good to go.
Let's see if the bots agree :-)

[commit-bot: I haz the power, 2013-10-01 20:49:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/23604064/16001

[commit-bot: I haz the power, 2013-10-01 23:39:11]

Change committed as 226343