Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3299)

Unified Diff: chrome/common/child_process_logging_posix.cc

Issue 23604061: Set the printer info in crash reports using the crash key logging system. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix memory issue Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/child_process_logging_mac.mm ('k') | chrome/common/child_process_logging_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/child_process_logging_posix.cc
diff --git a/chrome/common/child_process_logging_posix.cc b/chrome/common/child_process_logging_posix.cc
index e0c11a0a32fe101009c075b5f3b340ed809f3c6a..9bbb8046be61d28d7cdc5efd1c8f5ebbe06eb5f6 100644
--- a/chrome/common/child_process_logging_posix.cc
+++ b/chrome/common/child_process_logging_posix.cc
@@ -23,8 +23,6 @@ static const size_t kClientIdSize = 32 + 1;
// these strings to the browser.
char g_client_id[kClientIdSize];
-char g_printer_info[kPrinterInfoStrLen * kMaxReportedPrinterRecords + 1] = "";
-
static const size_t kNumSize = 32;
char g_num_switches[kNumSize] = "";
char g_num_variations[kNumSize] = "";
@@ -53,20 +51,6 @@ std::string GetClientId() {
return std::string(g_client_id);
}
-void SetPrinterInfo(const char* printer_info) {
- std::string printer_info_str;
- std::vector<std::string> info;
- base::SplitString(printer_info, L';', &info);
- DCHECK_LE(info.size(), kMaxReportedPrinterRecords);
- for (size_t i = 0; i < info.size(); ++i) {
- printer_info_str += info[i];
- // Truncate long switches, align short ones with spaces to be trimmed later.
- printer_info_str.resize((i + 1) * kPrinterInfoStrLen, ' ');
- }
- base::strlcpy(g_printer_info, printer_info_str.c_str(),
- arraysize(g_printer_info));
-}
-
void SetCommandLine(const CommandLine* command_line) {
const CommandLine::StringVector& argv = command_line->argv();
« no previous file with comments | « chrome/common/child_process_logging_mac.mm ('k') | chrome/common/child_process_logging_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698