chrome/browser/printing/print_system_task_proxy.cc - Issue 23604061: Set the printer info in crash reports using the crash key logging system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_system_task_proxy.cc

Issue 23604061: Set the printer info in crash reports using the crash key logging system. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix memory issue Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/printing/print_system_task_proxy.cc

diff --git a/chrome/browser/printing/print_system_task_proxy.cc b/chrome/browser/printing/print_system_task_proxy.cc

index 0868c1dbb778983aae5608b295a15ec8516953ec..2b8ad4ef28a921b55c5d34492d64cc0c26962162 100644

--- a/chrome/browser/printing/print_system_task_proxy.cc

+++ b/chrome/browser/printing/print_system_task_proxy.cc

@@ -12,7 +12,7 @@

#include "base/metrics/histogram.h"

#include "base/values.h"

#include "chrome/browser/ui/webui/print_preview/print_preview_handler.h"

-#include "chrome/common/child_process_logging.h"

+#include "chrome/common/crash_keys.h"

#include "printing/backend/print_backend.h"

#include "printing/print_job_constants.h"

#include "printing/print_settings.h"

@@ -112,7 +112,7 @@ void PrintSystemTaskProxy::SetupPrinterList(ListValue* printers) {

void PrintSystemTaskProxy::GetPrinterCapabilities(

const std::string& printer_name) {

VLOG(1) << "Get printer capabilities start for " << printer_name;

- child_process_logging::ScopedPrinterInfoSetter prn_info(

+ crash_keys::ScopedPrinterInfo crash_key(

print_backend_->GetPrinterDriverInfo(printer_name));

if (!print_backend_->IsValidPrinter(printer_name)) {

« no previous file with comments | « chrome/app/breakpad_win.cc ('k') | chrome/common/child_process_logging.h » ('j') | no next file with comments »