Issue 23604042: Implement startCopy and cancelCopy.

Issue 23604042: Implement startCopy and cancelCopy. (Closed)

Created:
7 years, 3 months ago by hidehiko

Modified:
7 years, 3 months ago

Reviewers:
kinaba

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implement startCopy and cancelCopy. This CL implements startCopy and cancelCopy of fileBrowserPrivate APIs. Note that startCopy works now, but cancellation and progress reporting are not supported yet. BUG=279288 TEST=Ran unit_tests and tested manually. R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222007

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase #

Patch Set 3 : Fix typo #

Patch Set 4 : Rebase #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+200 lines, -24 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager/event_router.h	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/event_router.cc	View	1 2 3	8 chunks	+50 lines, -18 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/private_api_file_system.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc	View	1 2	6 chunks	+138 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kinaba

lgtm https://codereview.chromium.org/23604042/diff/1/chrome/browser/chromeos/extensions/file_manager/event_router.cc File chrome/browser/chromeos/extensions/file_manager/event_router.cc (right): https://codereview.chromium.org/23604042/diff/1/chrome/browser/chromeos/extensions/file_manager/event_router.cc#newcode213 chrome/browser/chromeos/extensions/file_manager/event_router.cc:213: // Sends an event named |event_name| with arguemtns ...

7 years, 3 months ago (2013-09-09 04:07:49 UTC) #2

hidehiko

Thank you for your review! https://codereview.chromium.org/23604042/diff/1/chrome/browser/chromeos/extensions/file_manager/event_router.cc File chrome/browser/chromeos/extensions/file_manager/event_router.cc (right): https://codereview.chromium.org/23604042/diff/1/chrome/browser/chromeos/extensions/file_manager/event_router.cc#newcode213 chrome/browser/chromeos/extensions/file_manager/event_router.cc:213: // Sends an event ...

7 years, 3 months ago (2013-09-09 04:57:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23604042/10001

7 years, 3 months ago (2013-09-09 04:57:10 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23604042/32001

7 years, 3 months ago (2013-09-09 06:42:29 UTC) #5

hidehiko

7 years, 3 months ago (2013-09-09 11:34:51 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r222007 (presubmit successful).

Expand Messages | Collapse Messages