Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 23604039: Include console.log output in exceptions thrown for WebGL test failures. (Closed)

Created:
7 years, 3 months ago by Ken Russell (switch to Gerrit)
Modified:
7 years, 3 months ago
Reviewers:
Zhenyao Mo, dtu, bajones, Sami
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, apatrick_chromium, darin-cc_chromium.org, Sami
Visibility:
Public.

Description

Include console.log output in exceptions thrown for WebGL test failures. This eases debugging failures of the WebGL conformance tests run under Telemetry. BUG=280750 R=bajones@chromium.org, dtu@chromium.org, skyostil@chromium.org, zmo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/test/gpu/gpu_tests/webgl_conformance.py View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Ken Russell (switch to Gerrit)
zmo: OWNERS review please bajones, dtu: please review as well.
7 years, 3 months ago (2013-09-03 23:29:56 UTC) #1
Ken Russell (switch to Gerrit)
7 years, 3 months ago (2013-09-03 23:30:07 UTC) #2
Zhenyao Mo
On 2013/09/03 23:30:07, Ken Russell wrote: LGTM
7 years, 3 months ago (2013-09-04 00:00:08 UTC) #3
dtu
lgtm
7 years, 3 months ago (2013-09-04 00:05:14 UTC) #4
Sami
Thanks, lgtm!
7 years, 3 months ago (2013-09-04 13:07:22 UTC) #5
bajones
lgtm
7 years, 3 months ago (2013-09-04 17:05:38 UTC) #6
Ken Russell (switch to Gerrit)
7 years, 3 months ago (2013-09-04 17:48:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r221226 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698