Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 2360403003: Revert of Replaced different means of zone pooling/reusing by one zone segment pool (Closed)

Created:
4 years, 3 months ago by Michael Hablich
Modified:
4 years, 3 months ago
CC:
rmcilroy, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Replaced different means of zone pooling/reusing by one zone segment pool (patchset #3 id:120001 of https://codereview.chromium.org/2348303002/ ) Reason for revert: Blocks Roll https://codereview.chromium.org/2366733002/ Original issue's description: > Replaced different means of zone pooling/reusing by one zone segment pool > > BUG=v8:5409 > > Committed: https://crrev.com/a124feb0760896c8be61de08004a08c3bc9b4b3f > Cr-Commit-Position: refs/heads/master@{#39633} TBR=mstarzinger@chromium.org,verwaest@chromium.org,heimbuef@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5409 Committed: https://crrev.com/b88a848faf72a4ab0e2b476891cfede2631b7f01 Cr-Commit-Position: refs/heads/master@{#39651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+502 lines, -446 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/move-optimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 16 chunks +48 lines, -48 lines 0 comments Download
M src/compiler/pipeline-statistics.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/pipeline-statistics.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M src/compiler/scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/wasm-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
A src/compiler/zone-pool.h View 1 chunk +94 lines, -0 lines 0 comments Download
A src/compiler/zone-pool.cc View 1 chunk +138 lines, -0 lines 0 comments Download
D src/compiler/zone-stats.h View 1 chunk +0 lines, -92 lines 0 comments Download
D src/compiler/zone-stats.cc View 1 chunk +0 lines, -111 lines 0 comments Download
M src/isolate.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/zone/zone.h View 3 chunks +16 lines, -3 lines 0 comments Download
M src/zone/zone.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 2 chunks +3 lines, -1 line 0 comments Download
M test/unittests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A test/unittests/compiler/zone-pool-unittest.cc View 1 chunk +163 lines, -0 lines 0 comments Download
D test/unittests/compiler/zone-stats-unittest.cc View 1 chunk +0 lines, -160 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Hablich
Created Revert of Replaced different means of zone pooling/reusing by one zone segment pool
4 years, 3 months ago (2016-09-23 06:02:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360403003/1
4 years, 3 months ago (2016-09-23 06:02:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 06:02:32 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 06:02:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b88a848faf72a4ab0e2b476891cfede2631b7f01
Cr-Commit-Position: refs/heads/master@{#39651}

Powered by Google App Engine
This is Rietveld 408576698