Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2360403002: pRPC: Retry on certain transient HTTP failures. (Closed)

Created:
4 years, 3 months ago by dnj
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

pRPC: Retry on certain transient HTTP failures. AppEngine can directly return certain retriable HTTP failures before hitting the actual pRPC service. Modify the pRPC client to retry on these failures by default. BUG=chromium:649454 TEST=None R=iannucci@chromium.org, nodir@chromium.org Committed: https://github.com/luci/luci-go/commit/25b6d8dd95fb75b45fb7454c76cc0a4d7fa3e0fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -5 lines) Patch
M grpc/prpc/client.go View 1 chunk +10 lines, -1 line 0 comments Download
M grpc/prpc/client_test.go View 4 chunks +28 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
dnj
4 years, 3 months ago (2016-09-22 20:57:05 UTC) #1
nodir
lgt
4 years, 2 months ago (2016-09-26 16:31:08 UTC) #6
nodir
lgtm! looks good objectively
4 years, 2 months ago (2016-09-26 16:31:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360403002/1
4 years, 2 months ago (2016-09-26 16:33:40 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 16:45:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/25b6d8dd95fb75b45fb7454c76cc0a4d7fa3e0fc

Powered by Google App Engine
This is Rietveld 408576698