[XML Viewer crash] Store the reference of pretty-print div as tree to be used during the processing

Source/core/xml/XMLViewer.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  * 1. Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *
@@ skipping 54 matching lines @@
     tree.classList.add('pretty-print');
     tree.id = 'tree';
     window.onload = sourceXMLLoaded;
 }
 
 function sourceXMLLoaded()
 {
     var sourceXML = document.getElementById('webkit-xml-viewer-source-xml');
     if (!sourceXML)
         return; // Stop if some XML tree extension is already processing this document
+
+    // Momentarily detach the sourceXML from the DOM in order to not clash with
+    // any elements in the source XML having id="tree" attribute.
+    sourceXML.parentNode.removeChild(sourceXML);
+
     var root = document.getElementById('tree');

[abarth-chromium, 2013/09/04 02:02:40]

Why not save off the |tree| reference instead of calling getElementById here?

 
     for (var child = sourceXML.firstChild; child; child = child.nextSibling)
         nodeParentPairs.push({parentElement: root, node: child});
 
     for (var i = 0; i < nodeParentPairs.length; i++)
         processNode(nodeParentPairs[i].parentElement, nodeParentPairs[i].node);
 
     drawArrows();
     initButtons();
 
+    // Processing of the XML document is complete. Now attach the sourceXML back into the body
+    document.body.appendChild(sourceXML);
+
     if (typeof(onAfterWebkitXMLViewerLoaded) == 'function')
       onAfterWebkitXMLViewerLoaded();
 }
 
 // Tree processing.
 
 function processNode(parentElement, node)
 {
     if (!processNode.processorsMap) {
         processNode.processorsMap = {};
@@ skipping 327 matching lines @@
         expandButton.onmousedown = handleButtonMouseDown;
     }
 
 }
 
 function handleButtonMouseDown(e)
 {
    // To prevent selection on double click
    e.preventDefault();
 }