runtime/vm/flow_graph_optimizer.cc - Issue 23604024: Fix a compiler bug caused by Utils::IsPowerOfTwo treating zero as a power of two.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 23604024: Fix a compiler bug caused by Utils::IsPowerOfTwo treating zero as a power of two. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

===================================================================

--- runtime/vm/flow_graph_optimizer.cc (revision 27015)

+++ runtime/vm/flow_graph_optimizer.cc (working copy)

@@ -1230,7 +1230,7 @@

const Object& obj = right->AsConstant()->value();

if (!obj.IsSmi()) return false;

const intptr_t value = Smi::Cast(obj).Value();

- if ((value <= 0) || !Utils::IsPowerOfTwo(value)) return false;

+ if (!Utils::IsPowerOfTwo(value)) return false;

// Insert smi check and attach a copy of the original environment

// because the smi operation can still deoptimize.

« no previous file with comments | « runtime/platform/utils.h ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »