Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 23604023: Bump MaxRegularSpaceAllocationSize to InitialSemiSpaceSize() * 4/5 (Closed)

Created:
7 years, 3 months ago by Jakob Kummerow
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Bump MaxRegularSpaceAllocationSize to InitialSemiSpaceSize() * 4/5 to allow allocation of large packed arrays in paged spaces. BUG=v8:2790 R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16475

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
As discussed. PTAL.
7 years, 3 months ago (2013-09-02 13:06:28 UTC) #1
Michael Starzinger
LGTM with comments. https://codereview.chromium.org/23604023/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/23604023/diff/1/src/heap.cc#newcode195 src/heap.cc:195: ASSERT(MaxRegularSpaceAllocationSize() >= The initial_semispace_size might change ...
7 years, 3 months ago (2013-09-02 13:12:43 UTC) #2
Jakob Kummerow
Thanks for the review, landing. https://codereview.chromium.org/23604023/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/23604023/diff/1/src/heap.cc#newcode195 src/heap.cc:195: ASSERT(MaxRegularSpaceAllocationSize() >= On 2013/09/02 ...
7 years, 3 months ago (2013-09-02 13:35:10 UTC) #3
Jakob Kummerow
7 years, 3 months ago (2013-09-02 13:37:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r16475 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698