Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5060)

Unified Diff: build/landmines.py

Issue 23604016: Make landmines.py take an extra script via an env var. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix typo Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/landmines.py
diff --git a/build/landmines.py b/build/landmines.py
index f1a514c5e7e206c345a33febea6b3d840781999e..d419b8945cebe502bc68bbacb4325925385a1f95 100755
--- a/build/landmines.py
+++ b/build/landmines.py
@@ -106,6 +106,9 @@ def main():
gyp_helper.apply_chromium_gyp_env()
+ extra_script = os.environ.get('EXTRA_LANDMINES_SCRIPT')
+ if extra_script:
+ options.landmine_scripts.append(extra_script)
iannucci 2013/08/31 00:54:20 I would put this above the apply_chromium_gyp_env.
for target in ('Debug', 'Release', 'Debug_x64', 'Release_x64'):
landmines = []
for s in options.landmine_scripts:
@@ -113,6 +116,7 @@ def main():
stdout=subprocess.PIPE)
output, _ = proc.communicate()
landmines.extend([('%s\n' % l.strip()) for l in output.splitlines()])
+
set_up_landmines(target, landmines)
return 0
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698