tools/telemetry/telemetry/core/chrome/android_browser_backend.py - Issue 23604005: [Telemetry] Implement dirty profile generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/chrome/android_browser_backend.py

Issue 23604005: [Telemetry] Implement dirty profile generation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@generate_profile

Patch Set: Fix unit tests Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/browser_options.py ('K') | « tools/telemetry/telemetry/core/browser_options.py ('k') | tools/telemetry/telemetry/core/chrome/android_browser_finder.py » ('j') | tools/telemetry/telemetry/page/profile_generator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/chrome/android_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/chrome/android_browser_backend.py b/tools/telemetry/telemetry/core/chrome/android_browser_backend.py

index 4fae26cf9e6ab4b9a59b536a8c40587c16108cfd..25d7baacecd8f0ca3b3240ffea4410d5211200eb 100644

--- a/tools/telemetry/telemetry/core/chrome/android_browser_backend.py

+++ b/tools/telemetry/telemetry/core/chrome/android_browser_backend.py

@@ -270,6 +270,13 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

self._adb.RunShellCommand('rm %s' % self._backend_settings.cmdline_file)

self._adb.CloseApplication(self._backend_settings.package)

+ if self._options.output_profile_path:

+ logging.info("Pulling profile directory from device: '%s'->'%s'." %

+ (self._backend_settings.profile_dir,

+ self._options.output_profile_path))

+ self._adb.Pull(self._backend_settings.profile_dir,

+ self._options.output_profile_path)

def IsBrowserRunning(self):

pids = self._adb.ExtractPid(self._backend_settings.package)

return len(pids) != 0