Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2360373002: Fix a fuzzer crash in VideoFramePool (Closed)

Created:
4 years, 3 months ago by hubbe
Modified:
4 years, 3 months ago
Reviewers:
Dale Curtis, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a fuzzer crash in VideoFramePool It seems that providing random data to the VPX parser can make it call the video frame pool with illegal parameters. This currently causes a crash, let's make it return null, and the calling code already seems to handle that well. BUG=648849 Committed: https://crrev.com/2ba53c9cf88833aabbb642e53de195fb150e28f0 Cr-Commit-Position: refs/heads/master@{#420443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M media/base/video_frame_pool.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
hubbe
4 years, 3 months ago (2016-09-22 18:55:18 UTC) #2
DaleCurtis
lgtm
4 years, 3 months ago (2016-09-22 19:11:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360373002/1
4 years, 3 months ago (2016-09-22 20:18:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 20:24:24 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 20:30:20 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ba53c9cf88833aabbb642e53de195fb150e28f0
Cr-Commit-Position: refs/heads/master@{#420443}

Powered by Google App Engine
This is Rietveld 408576698