cocoa browser: remove non-material tabstrip support

cocoa browser: remove non-material tabstrip support

This is part 2 of removing non-material top chrome support.

BUG=649368
Committed: https://crrev.com/6087e041d0124f46e56d3e93f3ca37571cb0157a
Cr-Commit-Position: refs/heads/master@{#420644}

[Elly Fong-Jones, 2016-09-22 18:50:30]

Description was changed from

==========
cocoa browser: remove non-material tabstrip support

This is part 2 of removing non-material top chrome support.

BUG=649368
==========

to

==========
cocoa browser: remove non-material tabstrip support

This is part 2 of removing non-material top chrome support.

BUG=649368
==========

[Elly Fong-Jones, 2016-09-22 18:50:31]

ellyjones@chromium.org changed reviewers:
+ avi@chromium.org

[Elly Fong-Jones, 2016-09-22 18:50:37]

avi: ptal? :)

[Avi (use Gerrit), 2016-09-22 19:14:06]

stampity stamp lgtm

https://codereview.chromium.org/2360343003/diff/1/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabs/tab_controller.mm (right):

https://codereview.chromium.org/2360343003/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_controller.mm:74: return 246;
Style this to match the two functions above.

https://codereview.chromium.org/2360343003/diff/1/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabs/tab_view.mm (left):

https://codereview.chromium.org/2360343003/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_view.mm:143:
imageForResourceID(IDR_TAB_INACTIVE_CENTER, STROKE_NORMAL),
Are these images removed?

[Elly Fong-Jones, 2016-09-23 12:28:16]

https://codereview.chromium.org/2360343003/diff/1/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabs/tab_controller.mm (right):

https://codereview.chromium.org/2360343003/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_controller.mm:74: return 246;
On 2016/09/22 19:14:05, Avi wrote:
> Style this to match the two functions above.

Done.

https://codereview.chromium.org/2360343003/diff/1/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabs/tab_view.mm (left):

https://codereview.chromium.org/2360343003/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_view.mm:143:
imageForResourceID(IDR_TAB_INACTIVE_CENTER, STROKE_NORMAL),
On 2016/09/22 19:14:06, Avi wrote:
> Are these images removed?

Hm - they are no longer needed for mac cocoa browser, but still needed for mac
views browser, so I don't know if we can yank them or not.

[Elly Fong-Jones, 2016-09-23 12:28:25]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-09-23 12:28:26]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2360343003/#ps20001
(title: "restyle fn")

[commit-bot: I haz the power, 2016-09-23 12:28:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 12:36:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 12:36:17]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Elly Fong-Jones, 2016-09-23 14:23:25]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-09-23 14:23:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 14:38:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 14:38:12]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Elly Fong-Jones, 2016-09-23 17:16:04]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-09-23 17:16:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 17:24:57]

Description was changed from

==========
cocoa browser: remove non-material tabstrip support

This is part 2 of removing non-material top chrome support.

BUG=649368
==========

to

==========
cocoa browser: remove non-material tabstrip support

This is part 2 of removing non-material top chrome support.

BUG=649368
==========

[commit-bot: I haz the power, 2016-09-23 17:24:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-23 17:26:55]

Description was changed from

==========
cocoa browser: remove non-material tabstrip support

This is part 2 of removing non-material top chrome support.

BUG=649368
==========

to

==========
cocoa browser: remove non-material tabstrip support

This is part 2 of removing non-material top chrome support.

BUG=649368

Committed: https://crrev.com/6087e041d0124f46e56d3e93f3ca37571cb0157a
Cr-Commit-Position: refs/heads/master@{#420644}
==========

[commit-bot: I haz the power, 2016-09-23 17:26:56]

Patchset 2 (id:??) landed as
https://crrev.com/6087e041d0124f46e56d3e93f3ca37571cb0157a
Cr-Commit-Position: refs/heads/master@{#420644}