Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2360343002: Remove test-only |verify_domain_authentication|. (Closed)

Created:
4 years, 2 months ago by Bence
Modified:
4 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove test-only |verify_domain_authentication|. * Remove SpdySession::verify_domain_authentication. * Remove SpdySessionPeer::verify_domain_authentication. * Remove SpdySessionPoolPeer::DisableDomainAuthenticationVerification. * Add cert to HttpNetworkTransactionTest.UseIPConnectionPooling* unittests, change hostname in test to match cert. BUG=624073 Committed: https://crrev.com/a4d611d543851a8fac9c42ffe6947a39e5d7ef73 Cr-Commit-Position: refs/heads/master@{#420435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -34 lines) Patch
M net/http/http_network_transaction_unittest.cc View 8 chunks +17 lines, -16 lines 0 comments Download
M net/spdy/spdy_session.h View 2 chunks +0 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M net/spdy/spdy_session_pool.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_session_pool.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 2 months ago (2016-09-22 19:30:32 UTC) #6
Ryan Hamilton
LGTM! Best CL ever!
4 years, 2 months ago (2016-09-22 19:34:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360343002/1
4 years, 2 months ago (2016-09-22 19:49:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-22 19:56:01 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-22 20:15:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4d611d543851a8fac9c42ffe6947a39e5d7ef73
Cr-Commit-Position: refs/heads/master@{#420435}

Powered by Google App Engine
This is Rietveld 408576698