Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2360333003: Milo: Buildbot build grpc endpoint fix (Closed)

Created:
4 years, 2 months ago by Ryan Tseng
Modified:
4 years, 2 months ago
Reviewers:
martiniss, hinoka
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo: Buildbot build grpc endpoint fix Previous CL accidentally pointed to the endpoint that returned a Milo build (A generic build datastructure meant for both Luci and buildbot builds) instead of the buildbot build. BUG=642461 Committed: https://github.com/luci/luci-go/commit/13283dfe9fd2489e280bd3e9a3e6d15fd119e3b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M milo/appengine/buildbot/grpc.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
hinoka
ptal, tiny change
4 years, 2 months ago (2016-09-22 18:41:53 UTC) #4
martiniss
lgtm
4 years, 2 months ago (2016-09-22 18:43:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360333003/1
4 years, 2 months ago (2016-09-22 18:50:48 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-22 18:54:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/13283dfe9fd2489e280bd3e9a3e6d15fd119e3b5

Powered by Google App Engine
This is Rietveld 408576698