Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1987)

Issue 2360293002: Fix 'strict-dynamic' tests (generateURL / assert mismatch). (Closed)

Created:
4 years, 3 months ago by mikispag
Modified:
4 years, 2 months ago
CC:
Mike West, aaj, blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix 'strict-dynamic' tests (generateURL / assert mismatch, misplaced parentheses). BUG=589380 Committed: https://crrev.com/55f028c4c04f7b2b864fcafc730b76b635f86cbf Cr-Commit-Position: refs/heads/master@{#421152}

Patch Set 1 #

Patch Set 2 : Fix misplaced parentheses. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic.html View 1 10 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-whitelist.html View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360293002/1
4 years, 3 months ago (2016-09-22 14:39:17 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-22 14:39:18 UTC) #6
Mike West
LGTM. Thanks for fixing my stupids!
4 years, 2 months ago (2016-09-27 08:04:21 UTC) #11
Mike West
LGTM. Thanks for fixing my stupids!
4 years, 2 months ago (2016-09-27 08:04:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360293002/20001
4 years, 2 months ago (2016-09-27 08:54:04 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 08:59:33 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 09:03:03 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55f028c4c04f7b2b864fcafc730b76b635f86cbf
Cr-Commit-Position: refs/heads/master@{#421152}

Powered by Google App Engine
This is Rietveld 408576698