Bail out on bad size and height in CCodec_FaxDecoder::CreateDecoder

Bail out on bad width and height in CCodec_FaxDecoder::CreateDecoder

BUG=648935, 649436
Committed: https://pdfium.googlesource.com/pdfium/+/4dd613cb51c1d77ac2998f760325ed5b93f4ebf0

[kcwu, 2016-09-23 12:09:05]

Description was changed from

==========
Bail out on bad size and height in CCodec_FaxDecoder::CreateDecoder

BUG=648935
==========

to

==========
Bail out on bad width and height in CCodec_FaxDecoder::CreateDecoder

BUG=648935
==========

[kcwu, 2016-09-23 12:10:17]

kcwu@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[kcwu, 2016-09-23 12:12:23]

Description was changed from

==========
Bail out on bad width and height in CCodec_FaxDecoder::CreateDecoder

BUG=648935
==========

to

==========
Bail out on bad width and height in CCodec_FaxDecoder::CreateDecoder

BUG=648935,649436
==========

[Tom Sepez, 2016-09-23 16:05:33]

lgtm

https://codereview.chromium.org/2360283004/diff/1/testing/libfuzzer/pdf_codec...
File testing/libfuzzer/pdf_codec_fax_fuzzer.cc (right):

https://codereview.chromium.org/2360283004/diff/1/testing/libfuzzer/pdf_codec...
testing/libfuzzer/pdf_codec_fax_fuzzer.cc:32:
std::unique_ptr<CCodec_ScanlineDecoder> decoder;
nit: combine wth next line

std::unique_ptr<CCodec_ScanlineDecoder> decoder(
    fax_module.CreateDecoder( ... ));

[Lei Zhang, 2016-09-23 16:15:03]

lgtm

I'm fine with doing checks earlier.

[Lei Zhang, 2016-09-23 16:15:46]

https://codereview.chromium.org/2360283004/diff/1/testing/libfuzzer/pdf_codec...
File testing/libfuzzer/pdf_codec_fax_fuzzer.cc (right):

https://codereview.chromium.org/2360283004/diff/1/testing/libfuzzer/pdf_codec...
testing/libfuzzer/pdf_codec_fax_fuzzer.cc:32:
std::unique_ptr<CCodec_ScanlineDecoder> decoder;
On 2016/09/23 16:05:33, Tom Sepez wrote:
> nit: combine wth next line
> 
> std::unique_ptr<CCodec_ScanlineDecoder> decoder(
>     fax_module.CreateDecoder( ... ));
> 

I have a CL to clean up the nits. So let's just land this.

[Lei Zhang, 2016-09-23 16:15:52]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-09-23 16:15:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 16:26:53]

Description was changed from

==========
Bail out on bad width and height in CCodec_FaxDecoder::CreateDecoder

BUG=648935,649436
==========

to

==========
Bail out on bad width and height in CCodec_FaxDecoder::CreateDecoder

BUG=648935,649436

Committed:
https://pdfium.googlesource.com/pdfium/+/4dd613cb51c1d77ac2998f760325ed5b93f4...
==========

[commit-bot: I haz the power, 2016-09-23 16:26:54]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/4dd613cb51c1d77ac2998f760325ed5b93f4...