Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: components/ntp_snippets/BUILD.gn

Issue 2360263002: [NTPSnippets] Show all downloads on the NTP (3/3): Downloads provider. (Closed)
Patch Set: another win fix. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/BUILD.gn
diff --git a/components/ntp_snippets/BUILD.gn b/components/ntp_snippets/BUILD.gn
index 47102a4ca01adb756b8b8ab084382f0c0312e4fc..d43dcfc814da5c53642f14cd497735620700cdd1 100644
--- a/components/ntp_snippets/BUILD.gn
+++ b/components/ntp_snippets/BUILD.gn
@@ -116,8 +116,6 @@ source_set("unit_tests") {
"bookmarks/bookmark_last_visit_utils_unittest.cc",
"category_factory_unittest.cc",
"content_suggestions_service_unittest.cc",
- "mock_content_suggestions_provider_observer.cc",
- "mock_content_suggestions_provider_observer.h",
"offline_pages/recent_tab_suggestions_provider_unittest.cc",
"physical_web_pages/physical_web_page_suggestions_provider_unittest.cc",
"remote/ntp_snippet_unittest.cc",
@@ -133,6 +131,7 @@ source_set("unit_tests") {
deps = [
":ntp_snippets",
+ ":test_support",
"//base",
"//base/test:test_support",
"//components/bookmarks/browser",
@@ -140,7 +139,7 @@ source_set("unit_tests") {
"//components/image_fetcher",
"//components/leveldb_proto:test_support",
"//components/ntp_snippets/remote/proto",
- "//components/offline_pages",
+ "//components/offline_pages:offline_pages",
Marc Treib 2016/10/17 10:18:41 nit: ":offline_pages" isn't required, just "//comp
vitaliii 2016/10/26 00:07:55 Done.
"//components/offline_pages:test_support",
"//components/sessions",
"//components/sessions:test_support",
@@ -156,3 +155,21 @@ source_set("unit_tests") {
"//ui/gfx:test_support",
]
}
+
+source_set("test_support") {
+ testonly = true
+ sources = [
+ "mock_content_suggestions_provider_observer.cc",
+ "mock_content_suggestions_provider_observer.h",
+ "offline_pages/offline_pages_test_utils.cc",
+ "offline_pages/offline_pages_test_utils.h",
+ ]
+
+ deps = [
+ ":ntp_snippets",
+ "//base:base",
Marc Treib 2016/10/17 10:18:41 nit: Also here, ":base" isn't required
vitaliii 2016/10/26 00:07:56 Done.
+ "//components/offline_pages",
+ "//components/offline_pages:test_support",
+ "//testing/gmock",
+ ]
+}

Powered by Google App Engine
This is Rietveld 408576698