Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(1285)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: components/ntp_snippets/downloads/DEPS
Issue
2360263002
:
[NTPSnippets] Show all downloads on the NTP (3/3): Downloads provider. (Closed)
Patch Set: Marc's comments.
Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/BUILD.gn
chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
chrome/browser/ntp_snippets/downloads/DEPS
chrome/browser/ntp_snippets/downloads/download_suggestions_provider.h
chrome/browser/ntp_snippets/downloads/download_suggestions_provider.cc
chrome/browser/prefs/browser_prefs.cc
components/ntp_snippets/downloads/DEPS
components/ntp_snippets/offline_pages/DEPS
components/ntp_snippets/pref_names.h
components/ntp_snippets/pref_names.cc
View unified diff
|
Download patch
« chrome/browser/ntp_snippets/downloads/download_suggestions_provider.cc
('K') |
« chrome/browser/prefs/browser_prefs.cc
('k') |
components/ntp_snippets/offline_pages/DEPS »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include_rules = [
1 include_rules = [
2
"+chrome/browser/download",
Marc Treib
2016/10/11 12:07:42
You still need to remove the dependency here.
You still need to remove the dependency here.
vitaliii
2016/10/13 08:43:07
Done.
Show quoted text
On 2016/10/11 12:07:42, Marc Treib wrote: > You still need to remove the dependency here.
Done.
2 "+components/offline_pages",
3 "+components/offline_pages",
3
"+components/offline_pages/background",
4
]
4
]
OLD
NEW
« chrome/browser/ntp_snippets/downloads/download_suggestions_provider.cc
('K') |
« chrome/browser/prefs/browser_prefs.cc
('k') |
components/ntp_snippets/offline_pages/DEPS »
('j') |
no next file with comments »
Issue 2360263002: [NTPSnippets] Show all downloads on the NTP (3/3): Downloads provider. (Closed)
Created 4 years, 3 months ago by vitaliii
Modified 4 years, 1 month ago
Reviewers: Marc Treib, Bernhard Bauer, dgn
Base URL:
Comments: 288
This is Rietveld
408576698