components/ntp_snippets/offline_pages/DEPS - Issue 2360263002: [NTPSnippets] Show all downloads on the NTP (3/3): Downloads provider.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_snippets/offline_pages/DEPS

Issue 2360263002: [NTPSnippets] Show all downloads on the NTP (3/3): Downloads provider. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/ntp_snippets/downloads/download_suggestions_provider.cc ('K') | « components/ntp_snippets/downloads/download_suggestions_provider.cc ('k') | components/ntp_snippets/pref_names.h » ('j') | components/ntp_snippets/pref_names.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/offline_pages"	2 "+components/offline_pages",
	Marc Treib 2016/09/22 13:45:52 ? ? vitaliii 2016/10/11 08:15:56 The idea was to add a comma, while we have a DEPS Show quoted text On 2016/09/22 13:45:52, Marc Treib wrote: > ? The idea was to add a comma, while we have a DEPS approval. I am not sure whether the comma is required there, but if it is, then it is a shame to ask offline pages team for a new approval when we need to add new dependency (i.e. new line). Marc Treib 2016/10/11 12:07:39 I think we don't need any particular approval for Show quoted text On 2016/10/11 08:15:56, vitaliii wrote: > On 2016/09/22 13:45:52, Marc Treib wrote: > > ? > > The idea was to add a comma, while we have a DEPS approval. I am not sure > whether the comma is required there, but if it is, then it is a shame to ask > offline pages team for a new approval when we need to add new dependency (i.e. > new line). I think we don't need any particular approval for adding that comma - the DEPS checker should be smart enough for that. Anyway, this is fine. vitaliii 2016/10/13 08:43:04 Acknowledged. Show quoted text On 2016/10/11 12:07:39, Marc Treib wrote: > On 2016/10/11 08:15:56, vitaliii wrote: > > On 2016/09/22 13:45:52, Marc Treib wrote: > > > ? > > > > The idea was to add a comma, while we have a DEPS approval. I am not sure > > whether the comma is required there, but if it is, then it is a shame to ask > > offline pages team for a new approval when we need to add new dependency (i.e. > > new line). > > I think we don't need any particular approval for adding that comma - the DEPS > checker should be smart enough for that. Anyway, this is fine. Acknowledged.
3 ]	3 ]

OLD	NEW