[NTPSnippets] Show all downloads on the NTP (3/3): Downloads provider.

chrome/browser/ntp_snippets/content_suggestions_service_factory.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ntp_snippets/content_suggestions_service_factory.h"
 
 #include <utility>
 
 #include "base/feature_list.h"
 #include "base/files/file_path.h"
@@ skipping 36 matching lines @@
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/storage_partition.h"
 #include "google_apis/google_api_keys.h"
 #include "net/url_request/url_request_context_getter.h"
 
 #if defined(OS_ANDROID)
 #include "chrome/browser/android/chrome_feature_list.h"
 #include "chrome/browser/android/ntp/ntp_snippets_launcher.h"
 #include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
+#include "components/ntp_snippets/downloads/download_suggestions_provider.h"
 #include "components/ntp_snippets/offline_pages/offline_page_proxy.h"
 #include "components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h"
 #include "components/ntp_snippets/recent_tabs/recent_tab_suggestions_provider.h"
 #include "components/offline_pages/offline_page_model.h"
 
 using ntp_snippets::OfflinePageProxy;
 using ntp_snippets::PhysicalWebPageSuggestionsProvider;
 using ntp_snippets::RecentTabSuggestionsProvider;
 using offline_pages::OfflinePageModel;
 using offline_pages::OfflinePageModelFactory;
+using content::DownloadManager;
 #endif  // OS_ANDROID
 
 using bookmarks::BookmarkModel;
 using content::BrowserThread;
 using history::HistoryService;
 using image_fetcher::ImageFetcherImpl;
 using ntp_snippets::BookmarkSuggestionsProvider;
 using ntp_snippets::CategoryFactory;
 using ntp_snippets::ContentSuggestionsService;
+using ntp_snippets::DownloadSuggestionsProvider;

[Marc Treib, 2016/09/22 13:45:52]

I think this should also go into the OS_ANDROID section above?

[vitaliii, 2016/10/11 08:15:56]

Done.

 using ntp_snippets::NTPSnippetsDatabase;
 using ntp_snippets::NTPSnippetsFetcher;
 using ntp_snippets::NTPSnippetsService;
 using ntp_snippets::NTPSnippetsScheduler;
 using ntp_snippets::NTPSnippetsStatusService;
 using ntp_snippets::ForeignSessionsSuggestionsProvider;
 using ntp_snippets::TabDelegateSyncAdapter;
 using suggestions::ImageDecoderImpl;
 using suggestions::SuggestionsService;
 using suggestions::SuggestionsServiceFactory;
@@ skipping 11 matching lines @@
 #if defined(OS_ANDROID)
 void RegisterRecentTabProvider(
     const scoped_refptr<OfflinePageProxy>& offline_page_proxy,
     ContentSuggestionsService* service,
     CategoryFactory* category_factory,
     PrefService* pref_service) {
   auto provider = base::MakeUnique<RecentTabSuggestionsProvider>(
       service, category_factory, offline_page_proxy, pref_service);
   service->RegisterProvider(std::move(provider));
 }
+
+void RegisterDownloadsProvider(
+    const scoped_refptr<OfflinePageProxy>& offline_page_proxy,
+    DownloadManager* download_manager,
+    ContentSuggestionsService* service,
+    CategoryFactory* category_factory,
+    PrefService* pref_service) {
+  bool download_manager_ui_enabled =

[Marc Treib, 2016/09/22 13:45:52]

Instead of the explicit download_manager_ui_enabled flag, could we just pass in
null for the DownloadManager?

[vitaliii, 2016/10/11 08:15:56]

This variable has nothing to do with the DownloadManager itself.
It is true when "Downloads" UI is turned on (and so we show "More"
button). If it is false, we still show the section.

+      base::FeatureList::IsEnabled(chrome::android::kDownloadsUiFeature);
+  auto provider = base::MakeUnique<DownloadSuggestionsProvider>(
+      service, category_factory, offline_page_proxy, download_manager,
+      pref_service, download_manager_ui_enabled);
+  service->RegisterProvider(std::move(provider));
+}
 #endif  // OS_ANDROID
 
 void RegisterBookmarkProvider(BookmarkModel* bookmark_model,
                               ContentSuggestionsService* service,
                               CategoryFactory* category_factory,
                               PrefService* pref_service) {
   auto provider = base::MakeUnique<BookmarkSuggestionsProvider>(
       service, category_factory, bookmark_model, pref_service);
   service->RegisterProvider(std::move(provider));
 }
@@ skipping 120 matching lines @@
     ClearScheduledTasks();
     return service;
   }
 
   CategoryFactory* category_factory = service->category_factory();
 #if defined(OS_ANDROID)
   OfflinePageModel* offline_page_model =
       OfflinePageModelFactory::GetForBrowserContext(profile);
   scoped_refptr<OfflinePageProxy> offline_page_proxy(
       new OfflinePageProxy(offline_page_model));
+  DownloadManager* download_manager =
+      content::BrowserContext::GetDownloadManager(profile);
 #endif  // OS_ANDROID
   BookmarkModel* bookmark_model =
       BookmarkModelFactory::GetForBrowserContext(profile);
   SigninManagerBase* signin_manager =
       SigninManagerFactory::GetForProfile(profile);
   OAuth2TokenService* token_service =
       ProfileOAuth2TokenServiceFactory::GetForProfile(profile);
   SuggestionsService* suggestions_service =
       SuggestionsServiceFactory::GetForProfile(profile);
   SyncService* sync_service =
       ProfileSyncServiceFactory::GetSyncServiceForBrowserContext(profile);
 
 #if defined(OS_ANDROID)
   if (base::FeatureList::IsEnabled(
           ntp_snippets::kRecentOfflineTabSuggestionsFeature)) {
     RegisterRecentTabProvider(offline_page_proxy, service, category_factory,
                               pref_service);
   }
+
+  if (base::FeatureList::IsEnabled(ntp_snippets::kDownloadSuggestionsFeature)) {
+    RegisterDownloadsProvider(offline_page_proxy, download_manager, service,
+                              category_factory, pref_service);
+  }
 #endif  // OS_ANDROID
 
   // |bookmark_model| can be null in tests.
   if (base::FeatureList::IsEnabled(ntp_snippets::kBookmarkSuggestionsFeature) &&
       bookmark_model) {
     RegisterBookmarkProvider(bookmark_model, service, category_factory,
                              pref_service);
   }
 
 #if defined(OS_ANDROID)
   if (base::FeatureList::IsEnabled(
           ntp_snippets::kPhysicalWebPageSuggestionsFeature)) {
     RegisterPhysicalWebPageProvider(service, category_factory);
   }
 #endif  // OS_ANDROID
 
   if (base::FeatureList::IsEnabled(ntp_snippets::kArticleSuggestionsFeature)) {
     RegisterArticleProvider(signin_manager, token_service, suggestions_service,
                             service, category_factory, pref_service, profile);
   }
 
   if (base::FeatureList::IsEnabled(
           ntp_snippets::kForeignSessionsSuggestionsFeature)) {
     RegisterForeignSessionsProvider(sync_service, service, category_factory,
                                     pref_service);
   }
 
   return service;
 }