Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 2360253002: Content that starts before the first fragmentainer should stay where it is. (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Content that starts before the first fragmentainer should stay where it is. It should not undergo pagination, but rather remain in the underflow area of the first fragmentainer. There's no reason to pull everything into the content area of the first fragmentainer. BUG=591694 Committed: https://crrev.com/9c39d45041f1441a7e279fe32160df3db02b2213 Cr-Commit-Position: refs/heads/master@{#420353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/fragmentation/content-preceding-first-fragmentainer.html View 1 chunk +62 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 3 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 3 months ago (2016-09-22 15:31:40 UTC) #6
eae
Makes sense as does the impl. Thank you. LGTM
4 years, 3 months ago (2016-09-22 15:34:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360253002/1
4 years, 3 months ago (2016-09-22 15:35:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 15:40:41 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 15:42:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c39d45041f1441a7e279fe32160df3db02b2213
Cr-Commit-Position: refs/heads/master@{#420353}

Powered by Google App Engine
This is Rietveld 408576698