Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1520)

Unified Diff: test/cctest/test-assembler-arm.cc

Issue 2360243002: [arm] Clean up use of IsSupported and IsEnabled. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/globals.h ('k') | test/cctest/test-disasm-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-assembler-arm.cc
diff --git a/test/cctest/test-assembler-arm.cc b/test/cctest/test-assembler-arm.cc
index c9c31ba626cecd2dc5761587bbcc8c63a55ee0fd..de024f8869f3f74b64dab94151a96b603d93ef64 100644
--- a/test/cctest/test-assembler-arm.cc
+++ b/test/cctest/test-assembler-arm.cc
@@ -244,9 +244,8 @@ TEST(4) {
Assembler assm(isolate, NULL, 0);
Label L, C;
-
- if (CpuFeatures::IsSupported(VFP3)) {
- CpuFeatureScope scope(&assm, VFP3);
+ if (CpuFeatures::IsSupported(VFPv3)) {
+ CpuFeatureScope scope(&assm, VFPv3);
__ mov(ip, Operand(sp));
__ stm(db_w, sp, r4.bit() | fp.bit() | lr.bit());
@@ -450,62 +449,57 @@ static void TestRoundingMode(VCVTTypes types,
Assembler assm(isolate, NULL, 0);
- if (CpuFeatures::IsSupported(VFP3)) {
- CpuFeatureScope scope(&assm, VFP3);
+ Label wrong_exception;
- Label wrong_exception;
+ __ vmrs(r1);
+ // Set custom FPSCR.
+ __ bic(r2, r1, Operand(kVFPRoundingModeMask | kVFPExceptionMask));
+ __ orr(r2, r2, Operand(mode));
+ __ vmsr(r2);
- __ vmrs(r1);
- // Set custom FPSCR.
- __ bic(r2, r1, Operand(kVFPRoundingModeMask | kVFPExceptionMask));
- __ orr(r2, r2, Operand(mode));
- __ vmsr(r2);
+ // Load value, convert, and move back result to r0 if everything went well.
+ __ vmov(d1, value);
+ switch (types) {
+ case s32_f64:
+ __ vcvt_s32_f64(s0, d1, kFPSCRRounding);
+ break;
- // Load value, convert, and move back result to r0 if everything went well.
- __ vmov(d1, value);
- switch (types) {
- case s32_f64:
- __ vcvt_s32_f64(s0, d1, kFPSCRRounding);
- break;
+ case u32_f64:
+ __ vcvt_u32_f64(s0, d1, kFPSCRRounding);
+ break;
- case u32_f64:
- __ vcvt_u32_f64(s0, d1, kFPSCRRounding);
- break;
+ default:
+ UNREACHABLE();
+ break;
+ }
+ // Check for vfp exceptions
+ __ vmrs(r2);
+ __ tst(r2, Operand(kVFPExceptionMask));
+ // Check that we behaved as expected.
+ __ b(&wrong_exception, expected_exception ? eq : ne);
+ // There was no exception. Retrieve the result and return.
+ __ vmov(r0, s0);
+ __ mov(pc, Operand(lr));
- default:
- UNREACHABLE();
- break;
- }
- // Check for vfp exceptions
- __ vmrs(r2);
- __ tst(r2, Operand(kVFPExceptionMask));
- // Check that we behaved as expected.
- __ b(&wrong_exception,
- expected_exception ? eq : ne);
- // There was no exception. Retrieve the result and return.
- __ vmov(r0, s0);
- __ mov(pc, Operand(lr));
+ // The exception behaviour is not what we expected.
+ // Load a special value and return.
+ __ bind(&wrong_exception);
+ __ mov(r0, Operand(11223344));
+ __ mov(pc, Operand(lr));
- // The exception behaviour is not what we expected.
- // Load a special value and return.
- __ bind(&wrong_exception);
- __ mov(r0, Operand(11223344));
- __ mov(pc, Operand(lr));
-
- CodeDesc desc;
- assm.GetCode(&desc);
- Handle<Code> code = isolate->factory()->NewCode(
- desc, Code::ComputeFlags(Code::STUB), Handle<Code>());
+ CodeDesc desc;
+ assm.GetCode(&desc);
+ Handle<Code> code = isolate->factory()->NewCode(
+ desc, Code::ComputeFlags(Code::STUB), Handle<Code>());
#ifdef DEBUG
- OFStream os(stdout);
- code->Print(os);
+ OFStream os(stdout);
+ code->Print(os);
#endif
- F1 f = FUNCTION_CAST<F1>(code->entry());
- int res =
- reinterpret_cast<int>(CALL_GENERATED_CODE(isolate, f, 0, 0, 0, 0, 0));
- ::printf("res = %d\n", res);
- CHECK_EQ(expected, res);
- }
+ F1 f = FUNCTION_CAST<F1>(code->entry());
+ int res =
+ reinterpret_cast<int>(CALL_GENERATED_CODE(isolate, f, 0, 0, 0, 0, 0));
+ ::printf("res = %d\n", res);
+ CHECK_EQ(expected, res);
}
@@ -1051,9 +1045,8 @@ TEST(13) {
Assembler assm(isolate, NULL, 0);
Label L, C;
-
- if (CpuFeatures::IsSupported(VFP3)) {
- CpuFeatureScope scope(&assm, VFP3);
+ if (CpuFeatures::IsSupported(VFPv3)) {
+ CpuFeatureScope scope(&assm, VFPv3);
__ stm(db_w, sp, r4.bit() | lr.bit());
« no previous file with comments | « src/globals.h ('k') | test/cctest/test-disasm-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698