Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Issue 2360233004: [interpreter] Fix word32 vs word64 bug in CodeStubAssembler::UpdateFeedback. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Fix word32 vs word64 bug in CodeStubAssembler::UpdateFeedback. R=epertoso@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/d2626e30d915d0be464dd3aae2eaf3b5be8883dd

Patch Set 1 #

Patch Set 2 : Fix cctest, remove some dead code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M src/code-stub-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/compiler/regress-strict-equals-mixed-feedback.js View 1 chunk +13 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-23 07:57:13 UTC) #1
epertoso
4 years, 3 months ago (2016-09-23 07:59:23 UTC) #4
epertoso
lgtm
4 years, 3 months ago (2016-09-23 07:59:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360233004/1
4 years, 3 months ago (2016-09-23 08:08:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/13331) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 3 months ago (2016-09-23 08:35:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360233004/20001
4 years, 3 months ago (2016-09-23 11:39:12 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d2626e30d915d0be464dd3aae2eaf3b5be8883dd Cr-Commit-Position: refs/heads/master@{#39658}
4 years, 3 months ago (2016-09-23 11:41:19 UTC) #19
Benedikt Meurer
4 years, 3 months ago (2016-09-23 11:41:35 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d2626e30d915d0be464dd3aae2eaf3b5be8883dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698