Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2360233002: [heap] Only insert new slot set entries. (Closed)

Created:
4 years, 3 months ago by Hannes Payer (out of office)
Modified:
4 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Only insert new slot set entries. BUG=chromium:648973, chromium:648568 Committed: https://crrev.com/de42ed28626b990c88ccdaabfe8380a067ec1350 Cr-Commit-Position: refs/heads/master@{#39624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/heap/slot-set.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Hannes Payer (out of office)
4 years, 3 months ago (2016-09-22 12:17:44 UTC) #4
ulan
lgtm
4 years, 3 months ago (2016-09-22 12:18:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360233002/1
4 years, 3 months ago (2016-09-22 12:19:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 12:45:00 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 12:45:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de42ed28626b990c88ccdaabfe8380a067ec1350
Cr-Commit-Position: refs/heads/master@{#39624}

Powered by Google App Engine
This is Rietveld 408576698