Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1704)

Unified Diff: Source/devtools/front_end/TimelinePanel.js

Issue 236023006: TimelinePanel: REGRESSION fix for search in timeline panel (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelinePanel.js
diff --git a/Source/devtools/front_end/TimelinePanel.js b/Source/devtools/front_end/TimelinePanel.js
index 71fc05530a74916ff0cbe9bed06a2411dbc277d4..ffb690dec1a3a98f7fbb8ac588d1dba2b57e20d7 100644
--- a/Source/devtools/front_end/TimelinePanel.js
+++ b/Source/devtools/front_end/TimelinePanel.js
@@ -795,7 +795,7 @@ WebInspector.TimelinePanel.prototype = {
*/
_updateSearchHighlight: function(revealRecord, shouldJump, jumpBackwards)
{
- if (this._textFilter || !this._searchRegex) {
+ if (!this._textFilter.isEmpty() || !this._searchRegex) {
this._clearHighlight();
return;
}
@@ -1160,6 +1160,14 @@ WebInspector.TimelineTextFilter = function()
WebInspector.TimelineTextFilter.prototype = {
/**
+ * @return {boolean}
+ */
+ isEmpty: function()
+ {
+ return !this._regex;
+ },
+
+ /**
* @param {?RegExp} regex
*/
setRegex: function(regex)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698