Add WebMediaPlayer::timelineOffset() support to WebMediaPlayerImpl.

media/filters/ffmpeg_demuxer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/ffmpeg_demuxer.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/callback_helpers.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/metrics/sparse_histogram.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/sys_byteorder.h"
 #include "base/task_runner_util.h"
 #include "base/time/time.h"
 #include "media/base/audio_decoder_config.h"
 #include "media/base/bind_to_current_loop.h"
 #include "media/base/decoder_buffer.h"
 #include "media/base/decrypt_config.h"
 #include "media/base/limits.h"
 #include "media/base/media_log.h"
 #include "media/base/video_decoder_config.h"
 #include "media/ffmpeg/ffmpeg_common.h"
 #include "media/filters/ffmpeg_glue.h"
 #include "media/filters/ffmpeg_h264_to_annex_b_bitstream_converter.h"
 #include "media/filters/webvtt_util.h"
 #include "media/formats/webm/webm_crypto_helpers.h"
 
 namespace media {
 
+static base::Time ExtractTimelineOffset(AVFormatContext* format_context) {

[scherkus (not reviewing), 2014/04/15 00:53:40]

parsing code without tests makes me nervous

how about moving this to media/ffmpeg/ffmpeg_common.h and adding tests?

perhaps something like:
base::Time ConvertToTime(const char* ffmpeg_utc) { ... }

then you can keep the demuxer-related logic (e.g,. checking for webm/matroska,
getting the dictionary stuff) in ffmpeg_demuxer.cc

[acolwell GONE FROM CHROMIUM, 2014/04/16 01:01:08]

Done.

+  if (strstr(format_context->iformat->name, "webm") ||
+      strstr(format_context->iformat->name, "matroska")) {
+    const AVDictionaryEntry* entry =
+        av_dict_get(format_context->metadata, "creation_time", NULL, 0);
+
+    // Convert ffmpeg UTC representation (YYYY-MM-DD HH:MM:SS) to base::Time.

[scherkus (not reviewing), 2014/04/15 00:53:40]

s/ffmpeg/FFmpeg/

[acolwell GONE FROM CHROMIUM, 2014/04/16 01:01:08]

Done.

+    std::vector<std::string> fields;
+    std::vector<std::string> date_fields;
+    std::vector<std::string> time_fields;
+    base::Time::Exploded exploded;
+    exploded.millisecond = 0;
+
+    // TODO: Update this parsing code when FFmpeg returns sub-second

[scherkus (not reviewing), 2014/04/15 00:53:40]

TODO(acolwell)?

[acolwell GONE FROM CHROMIUM, 2014/04/16 01:01:08]

Done.

+    // information.
+    if (entry != NULL && entry->value != NULL &&
+        (Tokenize(entry->value, " ", &fields) == 2) &&
+        (Tokenize(fields[0], "-", &date_fields) == 3) &&
+        (Tokenize(fields[1], ":", &time_fields) == 3) &&
+        base::StringToInt(date_fields[0], &exploded.year) &&
+        base::StringToInt(date_fields[1], &exploded.month) &&
+        base::StringToInt(date_fields[2], &exploded.day_of_month) &&
+        base::StringToInt(time_fields[0], &exploded.hour) &&
+        base::StringToInt(time_fields[1], &exploded.minute) &&
+        base::StringToInt(time_fields[2], &exploded.second)) {
+      return base::Time::FromUTCExploded(exploded);
+    }
+  }
+
+  return base::Time();
+}
+
 //
 // FFmpegDemuxerStream
 //
 FFmpegDemuxerStream::FFmpegDemuxerStream(
     FFmpegDemuxer* demuxer,
     AVStream* stream)
     : demuxer_(demuxer),
       task_runner_(base::MessageLoopProxy::current()),
       stream_(stream),
       type_(UNKNOWN),
@@ skipping 432 matching lines @@
     }
   }
   return NULL;
 }
 
 base::TimeDelta FFmpegDemuxer::GetStartTime() const {
   DCHECK(task_runner_->BelongsToCurrentThread());
   return start_time_;
 }
 
+base::Time FFmpegDemuxer::GetWallclockTimelineOffset() const {
+  return wallclock_timeline_offset_;
+}
+
 void FFmpegDemuxer::AddTextStreams() {
   DCHECK(task_runner_->BelongsToCurrentThread());
 
   for (StreamVector::size_type idx = 0; idx < streams_.size(); ++idx) {
     FFmpegDemuxerStream* stream = streams_[idx];
     if (stream == NULL || stream->type() != DemuxerStream::TEXT)
       continue;
 
     TextKind kind = stream->GetTextKind();
     std::string title = stream->GetMetadata("title");
@@ skipping 168 matching lines @@
   // Some demuxers, like WAV, do not put timestamps on their frames. We
   // assume the the start time is 0.
   if (start_time_ == kNoTimestamp())
     start_time_ = base::TimeDelta();
 
   // MPEG-4 B-frames cause grief for a simple container like AVI. Enable PTS
   // generation so we always get timestamps, see http://crbug.com/169570
   if (strcmp(format_context->iformat->name, "avi") == 0)
     format_context->flags |= AVFMT_FLAG_GENPTS;
 
+  wallclock_timeline_offset_ = ExtractTimelineOffset(format_context);
+
   // Good to go: set the duration and bitrate and notify we're done
   // initializing.
   host_->SetDuration(max_duration);
   duration_known_ = (max_duration != kInfiniteDuration());
 
   int64 filesize_in_bytes = 0;
   url_protocol_->GetSize(&filesize_in_bytes);
   bitrate_ = CalculateBitrate(format_context, max_duration, filesize_in_bytes);
   if (bitrate_ > 0)
     data_source_->SetBitrate(bitrate_);
@@ skipping 293 matching lines @@
   }
   for (size_t i = 0; i < buffered.size(); ++i)
     host_->AddBufferedTimeRange(buffered.start(i), buffered.end(i));
 }
 
 void FFmpegDemuxer::OnDataSourceError() {
   host_->OnDemuxerError(PIPELINE_ERROR_READ);
 }
 
 }  // namespace media