Issue 23602016: Make index argument to HTMLOptionsCollection.remove() mandatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23602016: Make index argument to HTMLOptionsCollection.remove() mandatory (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
tkent, arv (Not doing code reviews)

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Make index argument to HTMLOptionsCollection.remove() mandatory Make index argument to HTMLOptionsCollection.remove() mandatory as per the specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmloptionscollection-0 This behavior is consistent with Firefox 23 and IE10. It is confusing what is expected to happen when no argument is given. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157055

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -43 lines)			Patch
M	LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/js/resources/select-options-remove.js	View	2 chunks	+20 lines, -20 lines	0 comments	Download
M	LayoutTests/fast/js/select-options-remove-expected.txt	View	2 chunks	+20 lines, -20 lines	0 comments	Download
M	Source/core/html/HTMLOptionsCollection.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23602016/1

7 years, 3 months ago (2013-09-02 02:21:28 UTC) #4

Message was sent while issue was closed.

Change committed as 157055