Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: tools/telemetry/telemetry/core/discover_unittest.py

Issue 23602015: [Telemetry] discover.DiscoverClasses() does not add inherited classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: disable pylint error Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/discover_unittest.py
diff --git a/tools/telemetry/telemetry/core/discover_unittest.py b/tools/telemetry/telemetry/core/discover_unittest.py
index dda14a360efa06cc1212f76d73e6cc764578d078..9fa0c1187d15a0ec148275ec21e90432821abc78 100644
--- a/tools/telemetry/telemetry/core/discover_unittest.py
+++ b/tools/telemetry/telemetry/core/discover_unittest.py
@@ -14,11 +14,10 @@ class DiscoverTest(unittest.TestCase):
base_class = Exception
classes = discover.DiscoverClasses(start_dir, base_dir, base_class)
self.assertTrue(len(classes) > 0)
-
- found_dummy_exception = False
for c in classes.values():
- if c.__name__ == 'DummyException':
- found_dummy_exception = True
self.assertTrue(issubclass(c, Exception))
- self.assertTrue(found_dummy_exception)
+ # discover_dummyclass is a base class and should not show up.
+ self.assertFalse('discover_dummyclass' in classes)
+ self.assertEqual(classes['another_discover_dummyclass'].__name__,
+ 'AnotherDummyException')

Powered by Google App Engine
This is Rietveld 408576698